Skip to content

fix memory leaks #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix memory leaks #178

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02c1dab
fix memory leaks
kyoji2 Oct 4, 2019
9664c6a
Merge pull request #1 from yannickl/master
kyoji2 May 6, 2025
e021d27
Update Package.swift
kyoji2 May 6, 2025
7add89f
update package
kyoji2 May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Sources/QRCodeReader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,8 @@ public final class QRCodeReader: NSObject, AVCaptureMetadataOutputObjectsDelegat

super.init()

sessionQueue.async {
sessionQueue.async { [weak self] in
guard let self = self else { return }
self.configureDefaultComponents(withCaptureDevicePosition: captureDevicePosition)
}
}
Expand Down Expand Up @@ -199,7 +200,8 @@ public final class QRCodeReader: NSObject, AVCaptureMetadataOutputObjectsDelegat
*Notes: if `stopScanningWhenCodeIsFound` is sets to true (default behaviour), each time the scanner found a code it calls the `stopScanning` method.*
*/
public func startScanning() {
sessionQueue.async {
sessionQueue.async { [weak self] in
guard let self = self else { return }
guard !self.session.isRunning else { return }
Comment on lines +204 to 205
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer one line guard. Is it possible to inline the first statement?

guard let self = self, !self.session.isRunning else { return }


self.session.startRunning()
Expand All @@ -212,7 +214,8 @@ public final class QRCodeReader: NSObject, AVCaptureMetadataOutputObjectsDelegat

/// Stops scanning the codes.
public func stopScanning() {
sessionQueue.async {
sessionQueue.async { [weak self] in
guard let self = self else { return }
guard self.session.isRunning else { return }
Comment on lines +218 to 219
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same here.

guard let self = self, self.session.isRunning else { return }


self.session.stopRunning()
Expand Down
8 changes: 4 additions & 4 deletions Sources/QRCodeReaderViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,18 +64,18 @@ public class QRCodeReaderViewController: UIViewController {

view.backgroundColor = .black

codeReader.didFindCode = { [weak self] resultAsObject in
codeReader.didFindCode = { [weak self, weak builder] resultAsObject in
if let weakSelf = self {
if let qrv = builder.readerView.displayable as? QRCodeReaderView {
if let qrv = builder?.readerView.displayable as? QRCodeReaderView {
qrv.addGreenBorder()
}
weakSelf.completionBlock?(resultAsObject)
weakSelf.delegate?.reader(weakSelf, didScanResult: resultAsObject)
}
}

codeReader.didFailDecoding = {
if let qrv = builder.readerView.displayable as? QRCodeReaderView {
codeReader.didFailDecoding = { [weak builder] in
if let qrv = builder?.readerView.displayable as? QRCodeReaderView {
qrv.addRedBorder()
}
}
Expand Down