Support cross system EOL markers #2
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This loader currently fails when building a package on Windows + the file's within the package have POSIX EOL markers. The root cause is that the loader splits the source file based on the underlying OS EOL marker - the loader is unable to break up the source code into individual lines as it is splitting the source file based on the Windows EOL marker (
\r\n
) even though the file only contains POSIX EOL markers (\n
);To solve this problem, this pull request splits the file based on either POSIX or Windows EOL markers.
Testing
NOTE: This solution was originally suggested in a previous pull request.