Skip to content

Conversation

@yusukebe
Copy link
Owner

@yusukebe yusukebe commented Mar 18, 2025

Fixes #61

@yusukebe yusukebe changed the title fix: remove /app from exclude fix: remove /app/** from exclude Mar 18, 2025
@yusukebe yusukebe merged commit 547085e into main Mar 18, 2025
8 checks passed
@yusukebe yusukebe deleted the fix/tweak-exclude branch March 18, 2025 07:34
@sialex-net
Copy link
Contributor

Hi @yusukebe
For me, this change broke some svg assets located in /app

Excluding in vite.config.ts fixes the issue but I'm not sure if the change might potentially affect a lot of react router projects because /app is a default directory?

@yusukebe
Copy link
Owner Author

@sialex-net

Oops. Sorry. Your problem should be solved. I'll work on it.

@yusukebe
Copy link
Owner Author

Hi @sialex-net

For me, this change broke some svg assets located in /app

Is the broken file extension .svg? Or are the other files broken as well? Only .svg?

@sialex-net
Copy link
Contributor

@sialex-net

Oops. Sorry. Your problem should be solved. I'll work on it.

No problem! Thank you!

@sialex-net
Copy link
Contributor

Hi @sialex-net

For me, this change broke some svg assets located in /app

Is the broken file extension .svg? Or are the other files broken as well? Only .svg?

Yes, file extension .svg

I just tried now with fonts (.woff2) and it's the same 404 error

import { defaultOptions } from '@hono/vite-dev-server';

serverAdapter({
  exclude: [...defaultOptions.exclude, '/app/**']
})

fixes it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional contexts can't get through loader function

3 participants