-
Notifications
You must be signed in to change notification settings - Fork 207
FEAT: Interactive registry login #4008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Interactive registry login #4008
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
|
I will figure out how to update the docs tomorrow |
|
Codecov Report❌ Patch coverage is
... and 43 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DCO, lint, and Docs and I believe this is in a good place. Functionality performs as expected for me locally.
|
I can get this done tonight hopefully - ansible-mans other account |
|
@brandtkeller Please let me know if there is anything else to be done here and I can get to it this week - ansible-man |
DCO needs signing - typically Otherwise the linting job has a few minor items that need to be adjusted otherwise this looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting feedback
src/cmd/crane.go
Outdated
| } | ||
| cmd.Flags().Set("password", pass) | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linting - remove this blank line
Signed-off-by: Cade Thomas <[email protected]>
Signed-off-by: Cade Thomas <[email protected]>
edfe951 to
638cea3
Compare
|
Hey @Ansible-man - looking at git history and surmising what might have gone wrong. I think we have a couple options - the most clear is going to be reseting: then re-resolving the linter changes. I'd push that - verify no conflicts - and then update the branch with changes from main. We can do the update once this is back to a clean slate. |
638cea3 to
d65005d
Compare
Signed-off-by: Cade Thomas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the issue description and conversation - I believe this fulfills the requirements. Thank you for the contribution! Will tag @zarf-dev/maintainers for a second review.
Description
This PR allows users to pass the --interactive flag to zarf tools registry login. This helps prevent credentials from being exposed to bash history and syslog. Fully backwards compatible with the existing flags the --interactive flag will only prompt the user for information they did not provide at command runtime.
...
Related Issue
#4003
Checklist before merging