Skip to content

Conversation

vincent-onebrief
Copy link
Contributor

@vincent-onebrief vincent-onebrief commented Sep 17, 2025

Description

The charts key supports merging, but doesn't support merging all properties. This isn't covered by the documentation well. Being able to override these properties allows for more complex CI testing where the zarf package needs to reference a derivative chart specific to the PR (as an example).

Related Issue

Checklist before merging

Copy link

netlify bot commented Sep 17, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 74dcce6
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/68cc51212378320008c17c0e

support merging helm chart properties url and version

Signed-off-by: vincent-onebrief <[email protected]>
@vincent-onebrief vincent-onebrief force-pushed the feat/merge-chart-properties branch from 8c1e92a to d64a4c2 Compare September 17, 2025 16:20
@vincent-onebrief vincent-onebrief marked this pull request as ready for review September 18, 2025 00:08
@vincent-onebrief vincent-onebrief requested review from a team as code owners September 18, 2025 00:08
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/pkg/packager/load/import.go 51.16% <100.00%> (+2.88%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I agree with this change. It doesn't really make sense to specify the url and version in your base zarf.yaml and for it to be impossible to have an effect. Have a minor the test / directory name

Signed-off-by: vincent-onebrief <[email protected]>
Copy link
Contributor

@AustinAbro321 AustinAbro321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now if your base zarf.yaml defines a chart.url or chart.version it will not be overwritten. While there would be no reason to specify the chart.url or chart.version before in this situation, I added a ! to denote that this is a breaking change if they were.

@AustinAbro321 AustinAbro321 changed the title feat: merge chart properties feat!: merge chart properties Sep 23, 2025
Copy link
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - appreciative of this gap being addressed.

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Sep 23, 2025
Merged via the queue into zarf-dev:main with commit 2dac690 Sep 23, 2025
28 of 29 checks passed
@vincent-onebrief vincent-onebrief deleted the feat/merge-chart-properties branch September 24, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants