-
Notifications
You must be signed in to change notification settings - Fork 200
feat!: merge chart properties #4193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: merge chart properties #4193
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
support merging helm chart properties url and version Signed-off-by: vincent-onebrief <[email protected]>
8c1e92a
to
d64a4c2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally I agree with this change. It doesn't really make sense to specify the url and version in your base zarf.yaml and for it to be impossible to have an effect. Have a minor the test / directory name
Signed-off-by: vincent-onebrief <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Now if your base zarf.yaml defines a chart.url
or chart.version
it will not be overwritten. While there would be no reason to specify the chart.url
or chart.version
before in this situation, I added a ! to denote that this is a breaking change if they were.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - appreciative of this gap being addressed.
Description
The
charts
key supports merging, but doesn't support merging all properties. This isn't covered by the documentation well. Being able to override these properties allows for more complex CI testing where the zarf package needs to reference a derivative chart specific to the PR (as an example).Related Issue
Checklist before merging