Skip to content

fix(ci): fix issue with nightly tag latest #4203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2025
Merged

fix(ci): fix issue with nightly tag latest #4203

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8ba2c0
fix(ci): fix issue with nightly tag latest
brandtkeller Sep 19, 2025
af04d67
fix(ci): remove whitespace
brandtkeller Sep 19, 2025
e940c97
Merge branch 'main' into fix_nightly_version_step
brandtkeller Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions .github/workflows/nightly-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,19 @@ jobs:
shell: bash
run: |
set -euo pipefail
# Get the latest tag (e.g., v1.2.3 or 1.2.3)
LATEST_TAG="$(git describe --tags --abbrev=0)"

# Preserve any non-numeric prefix (commonly "v")
PREFIX="${LATEST_TAG%%[0-9]*}" # "v" or ""
CORE="${LATEST_TAG#"$PREFIX"}" # strip prefix -> "1.2.3[-suffix][+build]"
# Find the latest stable semver tag (ignores prereleases, nightly, etc.)
LATEST_TAG="$(git tag --sort=-version:refname \
| grep -E '^v?[0-9]+\.[0-9]+\.[0-9]+$' \
| head -n1)"

# Strip any pre-release/build metadata from the core version
CORE="${CORE%%-*}" # drop "-rc1" etc.
CORE="${CORE%%+*}" # drop "+build" etc.
if [[ -z "${LATEST_TAG}" ]]; then
echo "No stable tags found, defaulting to 0.0.0"
LATEST_TAG="v0.0.0"
fi

PREFIX="${LATEST_TAG%%[0-9]*}" # usually "v" or ""
CORE="${LATEST_TAG#"$PREFIX"}"

IFS='.' read -r MAJOR MINOR PATCH <<<"${CORE}"
: "${MAJOR:=0}" ; : "${MINOR:=0}" ; : "${PATCH:=0}"
Expand All @@ -66,7 +69,6 @@ jobs:

echo "Computed nightly: ${NEW_TAG}"

# Outputs / ENV
echo "cli_version=${NEW_TAG}" >> "$GITHUB_OUTPUT"
echo "CLI_VERSION=${NEW_TAG}" >> "$GITHUB_ENV"

Expand Down
Loading