Skip to content

Conversation

ironhaven
Copy link
Contributor

The sketchy string literal parser is now less sketchy!

If a string with escape sequences is passed to any macro this patch will
parse the escapes. It will parse all escapes listed in the rust
reference except for \u{XXXX} Unicode escapes because they are complicated and non-ASCII is
explicitly unsupported.

All in the name of not adding syn to Cargo.toml.

ironhaven added 2 commits June 9, 2021 01:18
If a string with escape sequences is passed any macro this will
parse the escapes. This will parse all escapes listed in the rust
reference except for \u{XXXX} Unicode escapes because non ascii is not
supported

All in the name of not adding syn to Cargo.toml
@sffc sffc requested a review from Manishearth June 12, 2021 01:01
@Manishearth
Copy link
Collaborator

Would it be possible to rely on the absolution crate for this? That crate is explicitly designed for avoiding a syn dep but getting full token parsing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants