Emit token usage metadata in ACP notifications #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamstein
force-pushed
the
token-usage
branch
from
13f08b0 to
dc8d012
Compare
benbrandt
reviewed
Nov 24, 2025
Comment on lines
+1422
to
+1427
| update: SessionUpdate::AgentMessageChunk(ContentChunk { | ||
| content: ContentBlock::Text(TextContent { | ||
| text: String::new(), | ||
| annotations: None, | ||
| meta: None, | ||
| }), |
Member
There was a problem hiding this comment.
Hmm we shouldn't need to append an empty chunk ideally...
This is something on the todo list to support at the protocol level in someway, and I think this highlights the issue that there isn't a great way to send it.
Another option might be to send it on the turn end with the stop reason? Like store it on the state of the turn and submit it when we finish?
But I haven't seen how often we get these. Do you have an idea of how often these events happen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is change is needed in order to show something like the " 18% context left", similar to what codex-cli shows users. Exposing this info is a very natural todo for using codex via ACP, since when the codex context window gets nearly full, it starts getting noticeably "stupid"; running "/compact" then fixes the problem. However, if you don't know that the context is nearly full, it's very difficult to to know when to do /compact, and there's no other way to query for this information. That is is basically the only info shown all the time in codex-cli also perhaps hints at how important it is.