Skip to content
This repository was archived by the owner on Oct 13, 2025. It is now read-only.

Conversation

@awelzel
Copy link
Contributor

@awelzel awelzel commented Jun 4, 2025

I wonder if we should actually publish this kind of plugin somewhere officially, or integrate the functionality into Zeek as an optional feature.

I'm pretty impressed how "easy" it is to do cluster event latency monitoring using a Prometheus histogram with an external plugin now that we have all that infrastructure...

@awelzel awelzel force-pushed the topic/awelzel/event-metadata-plugin branch from 5445a05 to 3aba4a0 Compare June 4, 2025 18:31
@awelzel awelzel force-pushed the topic/awelzel/event-metadata-plugin branch from 1f32071 to 6190118 Compare July 28, 2025 12:54
@awelzel
Copy link
Contributor Author

awelzel commented Jul 28, 2025

@ckreibich - would you be up for skimming this through? It's just a short example how to use custom event metadata :-)

@awelzel awelzel requested a review from ckreibich July 28, 2025 12:56
Copy link
Member

@ckreibich ckreibich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it a lot. Cool example of things newly possible in Zeek, and integrating them into a modern environment. I just have a few nits — feel free to handle as you see fit.

Going forward I don't think we should add more full-blown plugins in the docs though, for a few reasons:

  • We won't catch errors in them as easily as if they were packages with CI etc
  • People need to clone zeek-docs to get to the source.
  • If people build on this, I'd argue they are more likely to ship the result in a package.

I think it'd be very nice to have "tutorial packages" for typical package/plugin scenarios that people can study. Sort of a more fleshed-out starting point than the raw package templates, that we can then link to from the docs. @bbannier also flagged the other day that it'd be nice to focus on building out more of a "utility ecosystem" for Zeek, so this could be part of that.

If you want to keep it here for now, I'm a-okay with that. But it seems fairly straightforward to make them packages, too.

@awelzel
Copy link
Contributor Author

awelzel commented Jul 29, 2025

We won't catch errors in them as easily as if they were packages with CI etc

I was fairly close putting a Dockerfile into this repo that just builds those two example plugins against zeek/zeek-dev :-)

But it seems fairly straightforward to make them packages, too.

Yeah, agree. Honest answer here unfortunately is that I'm steering clear of zkg whenever I can. The motivation for this PR was to document new plugin hooks, not building a package.

@awelzel awelzel force-pushed the topic/awelzel/event-metadata-plugin branch from 6190118 to 44078df Compare July 29, 2025 09:50
@awelzel awelzel merged commit 1c87867 into master Jul 29, 2025
11 checks passed
@awelzel awelzel deleted the topic/awelzel/event-metadata-plugin branch July 29, 2025 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants