Skip to content
This repository was archived by the owner on Oct 13, 2025. It is now read-only.

Conversation

@0xxon
Copy link
Member

@0xxon 0xxon commented Aug 6, 2025

No description provided.

Copy link
Member

@timwoj timwoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this section go away or be changed as well? https://github.com/zeek/zeek-docs/blob/master/script-reference/log-files.rst?plain=1#L294-L296

I ask because it's part of what's breaking the docs build on the deprecation-removal branch:

WARNING: script-reference/log-files: unknown target for ":zeek:type:`DPD::Info`"
WARNING: script-reference/log-files: unknown target for ":zeek:type:`DPD::Info`"

@ckreibich
Copy link
Member

Yep agree, that one can just go. It would be good for the text to call out the recent changes to this area in a note, but we don't have to hold up RC2 over it.

(Also, Tim and I spoke earlier and we agreed to add a redirect link so old links dpd.html still work.)

@evantypanski
Copy link
Contributor

we agreed to add a redirect link

To the zeek-docs? I thought we were over the limit by a few thousand last time I tried!

@timwoj
Copy link
Member

timwoj commented Aug 7, 2025

I thought we were over the limit by a few thousand last time I tried!

We also talked about removing all of the "Bro" redirects. It's been 6 years.

@ckreibich
Copy link
Member

I just opened #343 for the removal, so we can just focus on adding the one needed redirect here.

@ckreibich
Copy link
Member

Yep agree, that one can just go.

Whoops, that's wrong — for 8.0, it should remain there, because it looks like log-files.rst includes logs that are optionally enabled via policy scripts. For 8.0 this correctly resolves to the log pulled in via policy/frameworks/analyzer/deprecated-dpd-log.zeek. However, on the 8.1 branch we need a docs revision that then really does remove it.

I think the argument for the redirect is unaffected, since it's about the dedicted dpd.logs chapter.

@timwoj
Copy link
Member

timwoj commented Aug 11, 2025

Yep agree, that one can just go.

Whoops, that's wrong — for 8.0, it should remain there, because it looks like log-files.rst includes logs that are optionally enabled via policy scripts. For 8.0 this correctly resolves to the log pulled in via policy/frameworks/analyzer/deprecated-dpd-log.zeek. However, on the 8.1 branch we need a docs revision that then really does remove it.

I think the argument for the redirect is unaffected, since it's about the dedicted dpd.logs chapter.

For this PR then, we can merge it as-is. On the deprecation-removal branch, I can delete it. Does that sound right?

Copy link
Member

@ckreibich ckreibich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's merge this. We'll need to resolve the redirect handling outside of this PR.

@timwoj timwoj merged commit 5ebc0c0 into master Aug 11, 2025
11 checks passed
@timwoj timwoj deleted the topic/johanna/analyzer-log branch August 11, 2025 23:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants