-
Notifications
You must be signed in to change notification settings - Fork 71
Update for dpd.log->analyzer.log change #341
Conversation
timwoj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this section go away or be changed as well? https://github.com/zeek/zeek-docs/blob/master/script-reference/log-files.rst?plain=1#L294-L296
I ask because it's part of what's breaking the docs build on the deprecation-removal branch:
WARNING: script-reference/log-files: unknown target for ":zeek:type:`DPD::Info`"
WARNING: script-reference/log-files: unknown target for ":zeek:type:`DPD::Info`"
|
Yep agree, that one can just go. It would be good for the text to call out the recent changes to this area in a note, but we don't have to hold up RC2 over it. (Also, Tim and I spoke earlier and we agreed to add a redirect link so old links dpd.html still work.) |
To the zeek-docs? I thought we were over the limit by a few thousand last time I tried! |
We also talked about removing all of the "Bro" redirects. It's been 6 years. |
|
I just opened #343 for the removal, so we can just focus on adding the one needed redirect here. |
Whoops, that's wrong — for 8.0, it should remain there, because it looks like log-files.rst includes logs that are optionally enabled via policy scripts. For 8.0 this correctly resolves to the log pulled in via I think the argument for the redirect is unaffected, since it's about the dedicted dpd.logs chapter. |
For this PR then, we can merge it as-is. On the deprecation-removal branch, I can delete it. Does that sound right? |
ckreibich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's merge this. We'll need to resolve the redirect handling outside of this PR.
No description provided.