This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Use postgres-specific tables to read database schema#321
Open
mat128 wants to merge 1 commit intozendframework:masterfrom
Open
Use postgres-specific tables to read database schema#321mat128 wants to merge 1 commit intozendframework:masterfrom
mat128 wants to merge 1 commit intozendframework:masterfrom
Conversation
Contributor
|
@mat128 thank for the PR, it looks very good! We need to provide a test for this change. We have a |
Member
|
This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
Member
|
This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#48. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes performance issues noted in #199.
On my production server, the original query took 22 seconds to retrieve 272 rows. This new query takes 204ms and retrieves the same rows.
This is based off @alextech query in #199 and adapted to be a drop-in replacement (it returns the correct values for check_option and is_updatable.
Closes #199