-
-
Notifications
You must be signed in to change notification settings - Fork 11
fix: vscode extension syntax language id #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdates VSCode extension manifest: increments version to 3.0.6 and changes the zmodel-v3 grammar scope name from "source.zmodel" to "source.zmodel-v3". Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the syntax language identifier for the ZenStack VSCode extension by updating the scopeName to properly align with the language ID and incrementing the version number.
- Updates the scopeName from "source.zmodel" to "source.zmodel-v3" to match the language ID
- Increments the extension version from 3.0.5 to 3.0.6
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Claude finished @ymc9's task —— View job PR Review: VSCode Extension Syntax Language ID FixI've reviewed this PR that fixes the VSCode extension syntax language identifier. Here's my comprehensive analysis: Todo List:
Summary of ChangesThe PR makes two focused changes to
Code Quality & Best Practices ✅Excellent alignment and consistency:
Configuration consistency:
Potential Issues
|
|
Claude finished @ymc9's task —— View job PR Review: VSCode Extension Syntax Language ID FixI've reviewed this PR that fixes the VSCode extension syntax language identifier. Here's my comprehensive analysis: Todo List:
Summary of ChangesThe PR makes two focused changes to
Code Quality & Best Practices ✅Excellent alignment and consistency:
Configuration consistency:
Potential Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/ide/vscode/package.json(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
{packages,samples,tests}/**
📄 CodeRabbit inference engine (CLAUDE.md)
Packages are located in
packages/,samples/, andtests/
Files:
packages/ide/vscode/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-test (20.x)
🔇 Additional comments (1)
packages/ide/vscode/package.json (1)
4-4: Approve version bump; update CHANGELOG & verify packaging
Version in package.json is correctly set to 3.0.6—ensure the scope name change is noted in CHANGELOG and release notes. Please run thebuildandvsce packagescripts locally in packages/ide/vscode to confirm the manifest/version are correctly applied.
Summary by CodeRabbit