-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add complete test scaffolding support with --test flag for API projects #5176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kevwan 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
0abfda5
to
2c55ae4
Compare
Co-authored-by: kevwan <[email protected]>
Co-authored-by: kevwan <[email protected]>
2c55ae4
to
056c5df
Compare
@copilot I left some review comments, please change the related code. thanks! |
…ity and add trailing newlines Co-authored-by: kevwan <[email protected]>
All review comments have been addressed in commit d5c4210:
The test scaffolding functionality remains intact and now follows the requested conventions. |
tools/goctl/api/gogen/jwt.api
Outdated
service A-api { | ||
@handler GreetHandler | ||
get /greet/from/:name(Request) returns (Response) | ||
} No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot you missed this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit ea7561a. Added the missing trailing newline to jwt.api file.
Co-authored-by: kevwan <[email protected]>
--with-tests
back to--test
All PR review feedback has been successfully addressed. The test scaffolding feature now:
--test
flag for backward compatibility✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.