Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 14, 2025

  • Implement complete test scaffolding with --test flag
  • Fix backward compatibility: revert flag name from --with-tests back to --test
  • Add trailing newlines to all newly created files (including jwt.api)
  • Validate changes work correctly
  • Reply to reviewer comments

All PR review feedback has been successfully addressed. The test scaffolding feature now:

  • Uses the original --test flag for backward compatibility
  • Generates all four types of test files (handler, logic, service context, integration)
  • Follows Go conventions with proper trailing newlines on ALL created files
  • Maintains the same comprehensive functionality as originally implemented

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor Author

Copilot AI commented Sep 14, 2025

@kevwan 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

@Copilot Copilot AI changed the title [WIP] goctl should generate test scaffolding for API projects Add complete test scaffolding support with --with-tests flag for API projects Sep 14, 2025
@Copilot Copilot AI requested a review from kevwan September 14, 2025 11:48
Copilot finished work on behalf of kevwan September 14, 2025 11:48
@kevwan kevwan requested a review from kesonan September 20, 2025 14:04
@kevwan kevwan marked this pull request as ready for review September 20, 2025 14:34
@kevwan
Copy link
Contributor

kevwan commented Sep 27, 2025

@copilot I left some review comments, please change the related code. thanks!

Copy link
Contributor Author

Copilot AI commented Sep 27, 2025

@copilot I left some review comments, please change the related code. thanks!

All review comments have been addressed in commit d5c4210:

  • Reverted flag name from --with-tests to --test for backward compatibility
  • Added trailing newlines to all newly created files

The test scaffolding functionality remains intact and now follows the requested conventions.

service A-api {
@handler GreetHandler
get /greet/from/:name(Request) returns (Response)
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot you missed this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit ea7561a. Added the missing trailing newline to jwt.api file.

@Copilot Copilot AI changed the title Add complete test scaffolding support with --with-tests flag for API projects Add complete test scaffolding support with --test flag for API projects Sep 27, 2025
@Copilot Copilot AI requested a review from kevwan September 27, 2025 13:03
Copilot finished work on behalf of kevwan September 27, 2025 13:03
Copilot finished work on behalf of kevwan September 27, 2025 13:07
@kevwan kevwan merged commit 271f105 into master Sep 27, 2025
9 checks passed
@kevwan kevwan deleted the copilot/fix-5128 branch September 27, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants