Skip to content

Annotation validation refactoring#1971

Merged
DerManoMann merged 1 commit intozircote:masterfrom
DerManoMann:validation-improvements
Mar 6, 2026
Merged

Annotation validation refactoring#1971
DerManoMann merged 1 commit intozircote:masterfrom
DerManoMann:validation-improvements

Conversation

@DerManoMann
Copy link
Collaborator

@DerManoMann DerManoMann commented Mar 3, 2026

Summary

Refactor annotation validation.

  • allows to override the logger used during validation to capture all validation logging separately
  • simplify the recursive logic
  • validation is now always run completely, not aborted on error
  • Validation version can now be overridden

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Enhancement (improvement to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactor (no functional changes)
  • Chore (maintenance, dependencies, CI)

Related Issues

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • New and existing tests pass locally
  • Any dependent changes have been merged and published

@DerManoMann DerManoMann changed the title keep validation in annotations Annotation validation refactoring Mar 6, 2026
@DerManoMann DerManoMann merged commit e7fa8bb into zircote:master Mar 6, 2026
14 checks passed
@DerManoMann DerManoMann deleted the validation-improvements branch March 6, 2026 01:06
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Created backport PR for 5.x:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-1971-to-5.x
git worktree add --checkout .worktree/backport-1971-to-5.x backport-1971-to-5.x
cd .worktree/backport-1971-to-5.x
git reset --hard HEAD^
git cherry-pick -x e7fa8bb8b25f554381d8d06c74d7c485e9f3644a
git push --force-with-lease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant