Skip to content

Conversation

snoyer
Copy link
Contributor

@snoyer snoyer commented Aug 11, 2025

Currently zmk_ble_active_profile_changed events are raised when the state of the active profile changes but we don't get notified if the state of any other profiles changes.
This means that, for example, the nice!view display of individual profile states (#2265) will not update if a device that is not on the active profile disconnects on its own.

This PR adds a zmk_ble_other_profile_changed (similar to the existing zmk_ble_active_profile_changed) that gets raised from the connected() and disconnected() methods when the connection is not the active one.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

@snoyer snoyer requested a review from a team as a code owner August 11, 2025 06:57
@caksoylar
Copy link
Contributor

Does this also address #2872 similar to #2873?

@snoyer
Copy link
Contributor Author

snoyer commented Aug 11, 2025

Does this also address #2872 similar to #2873?

According to the implementation of #2873, no, this one doesn't expose or react to the advertising state.
But according to the description of #2872, I'd say yes, it does let you know about profiles other than the active one. Would need @adolto to confirm whether they actually need the advertising details.

@snoyer snoyer force-pushed the other_profile_changed-event branch from e39bac9 to dd4b7d0 Compare August 12, 2025 08:54
@nmunnich nmunnich added the bluetooth Bluetooth related items label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bluetooth Bluetooth related items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants