Skip to content

Conversation

DuMaM
Copy link

@DuMaM DuMaM commented Aug 21, 2025

This PR adds support for ZMK Studio on Ergodash keyboard

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

@DuMaM DuMaM changed the title feat: add support for zmk studio feat: add support for zmk studio in ergodash Aug 21, 2025
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While these were discussed on Discord, also leaving the comments here for posterity. Would be good to have these fixed so we can tick this keyboard off the list.

Comment on lines +6 to +7
select ZMK_STUDIO
select ZMK_STUDIO_TRANSPORT_BLE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these, Studio isn't enabled by default

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is extra and should be removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary, please remove

&trans &none &none &none &none &none &none &none &none &none &none &bootloader &sys_reset &trans
&trans &none &none &trans &trans &none &trans &trans &none &trans &none &none &none &trans
&trans &none &none &none &none &none &none &none &none &none &none &bootloader &sys_reset &trans
&trans &bt BT_PRV &bt BT_NXT &trans &trans &none &trans &trans &none &trans &none &none &none &trans
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated, I'd remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used and unnecessary, please remove

Comment on lines +1 to +6
#
# Copyright (c) 2020 The ZMK Contributors
#
# SPDX-License-Identifier: MIT
#

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd undo this header addition, not really necessary

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary, please remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary, please remove

Comment on lines +412 to +419








Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

display-name = "LAYOUT_3key_2us";

kscan = <&kscan0>;
transform = <&default_transform_3key>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems incorrect: the key ordering shows that in this case all 6 thumb keys should be on the last row of the keymap (see image) but the matrix transform has two of the thumbs on the upper row (consistent with LAYOUT_3key_1us but not this one). I guess this one needs a different matrix transform, or reordered keys.

image

Copy link
Contributor

@nmunnich nmunnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See caksoylar's comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants