-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat: add support for zmk studio in ergodash #3041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add support for zmk studio in ergodash #3041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While these were discussed on Discord, also leaving the comments here for posterity. Would be good to have these fixed so we can tick this keyboard off the list.
select ZMK_STUDIO | ||
select ZMK_STUDIO_TRANSPORT_BLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these, Studio isn't enabled by default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is extra and should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary, please remove
&trans &none &none &none &none &none &none &none &none &none &none &bootloader &sys_reset &trans | ||
&trans &none &none &trans &trans &none &trans &trans &none &trans &none &none &none &trans | ||
&trans &none &none &none &none &none &none &none &none &none &none &bootloader &sys_reset &trans | ||
&trans &bt BT_PRV &bt BT_NXT &trans &trans &none &trans &trans &none &trans &none &none &none &trans |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is unrelated, I'd remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not used and unnecessary, please remove
# | ||
# Copyright (c) 2020 The ZMK Contributors | ||
# | ||
# SPDX-License-Identifier: MIT | ||
# | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd undo this header addition, not really necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary, please remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary, please remove
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
display-name = "LAYOUT_3key_2us"; | ||
|
||
kscan = <&kscan0>; | ||
transform = <&default_transform_3key>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems incorrect: the key ordering shows that in this case all 6 thumb keys should be on the last row of the keymap (see image) but the matrix transform has two of the thumbs on the upper row (consistent with LAYOUT_3key_1us
but not this one). I guess this one needs a different matrix transform, or reordered keys.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See caksoylar's comments
This PR adds support for ZMK Studio on Ergodash keyboard
PR check-list