Skip to content

Refactor implementation #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 6, 2024
Merged

Refactor implementation #5

merged 6 commits into from
Dec 6, 2024

Conversation

aryanmehrotra
Copy link
Contributor

  1. Stop storing file while loading the application rather check if file exists while serving.
  2. Add Tests
  3. Directory to read contents is now configurable by setting the relative path on env variable STATIC_FILE_PATH.

@aryanmehrotra aryanmehrotra changed the base branch from development to main December 6, 2024 12:43
@aryanmehrotra aryanmehrotra changed the base branch from main to development December 6, 2024 12:44
@aryanmehrotra aryanmehrotra changed the title Enhance implementation Refactor implementation Dec 6, 2024
@PiyushSingh-ZS PiyushSingh-ZS merged commit 4edfade into development Dec 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiyushSingh-ZS PiyushSingh-ZS PiyushSingh-ZS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryanmehrotra @PiyushSingh-ZS