-
Notifications
You must be signed in to change notification settings - Fork 773
Version-aware MAKE_FUNCTION_A and MAKE_CLOSURE_A support #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Dear @greenozon and @zrax, I would greatly appreciate it if you could review this pull request at your convenience. Your insights and feedback will be very valuable in ensuring the quality and reliability of these changes. Thank you in advance for your time and consideration. |
|
Thank you very much for your review, @greenozon — your feedback is greatly appreciated. |
|
Dear @whoami730 , Thank you in advance for your time and consideration. |
|
Hello @whoami730, could you kindly assist me in fixing the tokenized files? I would greatly appreciate your help. |
|
Note on title - there is no |
|
Dear @zrax, @greenozon, and @whoami730, I would greatly appreciate it if you could review this pull request at your convenience. Your insights and feedback will be very valuable in ensuring the quality and reliability of these changes. Thank you in advance for your time and consideration. |
|
Sorry for the delay, I don't have much time to work on pycdc these days. This change adds a bunch of new features, but the only test added is fairly trivial... Is there a plan to add at least basic tests for some of the new functionality? |
Summary
This PR replaces the existing counts-only implementation of
MAKE_FUNCTION_AandMAKE_CLOSURE_Awith a version-aware handler that supports all Python 3.x releases up to 3.14+.Previous behavior
New behavior
0x10), ensuring forward compatibility.Outcome