Open
Conversation
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Contributor
|
Hey chris, apologies, I still didn't have time to test. |
Member
Author
|
@dschall I've updated this to use the |
9b3a60e to
4f2cb3d
Compare
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
1 task
4f2cb3d to
636e997
Compare
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
Signed-off-by: Chris Jackson <chris@cd-jackson.com>
636e997 to
5ca6b96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something I wrote a while back but didn't create a PR so I need to try and remember how it all works :)
This creates a
ZigBeeUtcTimeclass for managing time on a remote device. It then supports aZigBeeTimeExtensionwhich in turn can provide a localZclTimeClientorZclTimeServerto manage the time on the remote device.The
ZclTimeServeris relatively simple in that it just responds to requests from the device.The
ZclTimeClientis in itself also simple in that it provides methods to set the time on the remote.The
ZigBeeTimeExtensiontries to automate the time management by working out drift rates, and setting the clock proactively if the time has drifted outside spec and the device didn't update the time through a request to theZclTimeServer.There is also a
ZigBeeConsoleTimeCommandconsole command to get or set the time, and display the various information.This is potentially a breaking change if people are using time at the moment since this changes some interfaces from
CalendartoZigBeeUtcTime.I welcome comments on this and will wait a week or two before merging.
Signed-off-by: Chris Jackson chris@cd-jackson.com