Open
Conversation
…d escaped JSON strings The regex that marks large integers (16+ digits) for BigInt handling was blindly replacing all matches, including numbers inside JSON string values. This corrupted the JSON structure (inserting unescaped quotes inside strings), causing JSON.parse to fail and fall back to eval-based parsing which loses integer precision. Fix: Add an offset-based string context check (consistent with json-worker.js and format-lib.js) that tracks whether the match position is inside a JSON string by scanning for unescaped quote characters. Numbers inside strings are left untouched. Co-authored-by: wjfz <3372236+wjfz@users.noreply.github.com>
Fix BigInt precision loss in parseWithBigInt for JSON with nested escaped JSON strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复前：
修复后：
{ "body":{ "data":{ "account_id":1401004938049356981 } }, "rawBody":"{\"data\":{\"account_id\":1401004938049356981}" }