Adding code to run on Powersystem excluding older GO versions#19
Open
genisysram wants to merge 2 commits intozyedidia:masterfrom
Open
Adding code to run on Powersystem excluding older GO versions#19genisysram wants to merge 2 commits intozyedidia:masterfrom
genisysram wants to merge 2 commits intozyedidia:masterfrom
Conversation
Author
|
@zyedidia |
Owner
|
I don't see what this adds to the project. What's the point of testing this architecture in the travis? FYI this is just a fork of gdamore/tcell, so we rely more on their continuous integration and correctness and just keep this fork up to date when features are needed from upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
Here is my contribution to your code, its working good on powersystems.
Thanks for the code, its working good.
What do these changes do?
Added Architecture "ppc64le"
Are there changes in behavior for the user?
No