Skip to content

MavLinkParam: Fix error when float param value is larger than decimal.MaxValue #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MavLinkParam: Fix error when float param value is larger than decimal.MaxValue #3275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80bd868
Fix error when float param value is larger than decimal.MaxValue
EosBandi Jan 15, 2024
0421442
Merge branch 'master' into fixfloat
meee1 Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions ExtLibs/Mavlink/MAVLinkParam.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,18 @@ public double GetValue()
0.8
(double)item.float_value
0.800000011920929
*/
return Math.Round((double)float_value, 7);
*/ {
//In case of very large numbers, decimal conversion could fail. In that case fall back to straight double conversion
try
{
return (double)(decimal)float_value;

}
catch
{
return Math.Round((double)float_value, 7);
}
}
}

throw new FormatException("invalid type");
Expand Down