-
Notifications
You must be signed in to change notification settings - Fork 462
Fix for - Running func new in an empty directory creates incorrect fi… #4661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
// Ensure that the _templates are loaded before we proceed | ||
_templates = await _templatesManager.Templates; | ||
|
||
// Ensure that the worker runtime and language are set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only changes in this PR is a comment, was there meant to be something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes Lilian, after reverting only this comment is the addition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I don't understand how this makes sense, what does a comment have to do with the original issue?
In the issue, you mention:
@liliankasem have checked the issue and debugged, found out that little line order change in the code to check the language and runtime been selected before creating any templates if we run 'func new' without 'func init' will resolve this issue by changing the line order of 116 prior to 114 - https://github.com/Azure/azure-functions-core-tools/blob/main/src/Cli/func/Actions/LocalActions/CreateFunctionAction.cs
This makes sense so I was expecting this PR to swap around these checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @liliankasem ... the fix which was mentioned throwing build error for some test cases, so we are fixing it and will remove the unnecessary comments in the next fix shortly
Hi @SatishKalluri - I have a prosposed solution for this issue: #4672 Do you mind working of that branch instead to ensure edge cases are accounted for and tests are write where needed? |
Hi @liliankasem, Sure |
Yes, please do that |
…les for dotnet #4581
Fix for - Running func new in an empty directory creates incorrect files
resolves #4581
Pull request checklist
release_notes.md
Additional information
Additional PR information