-
Notifications
You must be signed in to change notification settings - Fork 462
Fix for - Running func new in an empty directory creates incorrect fi… #4661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3766cd2
Fix for - Running func new in an empty directory creates incorrect fi…
SatishKalluri f2ddcee
Reverting changes as Test failing
SatishKalluri 62b6423
Updated fix for - Running func new in an empty directory
SatishKalluri 78c358c
Refactor test to use Fact instead of Theory
SatishKalluri 364670a
Removed unnecessary code
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// Copyright (c) .NET Foundation. All rights reserved. | ||
// Licensed under the MIT License. See LICENSE in the project root for license information. | ||
|
||
using Azure.Functions.Cli.Actions.LocalActions; | ||
using Xunit; | ||
|
||
namespace Func.UnitTests.ActionsTests | ||
{ | ||
public class InitActionHostJsonTests | ||
{ | ||
private readonly string _testDir; | ||
|
||
public InitActionHostJsonTests() | ||
{ | ||
_testDir = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString()); | ||
Directory.CreateDirectory(_testDir); | ||
Directory.SetCurrentDirectory(_testDir); | ||
} | ||
|
||
[Fact] | ||
public void DeleteOrOverwriteHostJsonIfOnlyFile_DeletesHostJson_WhenOnlyFilePresent() | ||
{ | ||
// Arrange | ||
var hostJsonPath = Path.Combine(_testDir, "host.json"); | ||
File.WriteAllText(hostJsonPath, "{ \"test\": true }"); | ||
|
||
// Act | ||
InitAction.DeleteOrOverwriteHostJsonIfOnlyFile(); | ||
|
||
// Assert | ||
Assert.False(File.Exists(hostJsonPath)); | ||
} | ||
|
||
[Fact] | ||
public void DeleteOrOverwriteHostJsonIfOnlyFile_DoesNotDeleteHostJson_WhenOtherFilesPresent() | ||
{ | ||
// Arrange | ||
var hostJsonPath = Path.Combine(_testDir, "host.json"); | ||
var otherFilePath = Path.Combine(_testDir, "other.txt"); | ||
File.WriteAllText(hostJsonPath, "{ \"test\": true }"); | ||
File.WriteAllText(otherFilePath, "other"); | ||
|
||
// Act | ||
InitAction.DeleteOrOverwriteHostJsonIfOnlyFile(); | ||
|
||
// Assert | ||
Assert.True(File.Exists(hostJsonPath)); | ||
Assert.True(File.Exists(otherFilePath)); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only changes in this PR is a comment, was there meant to be something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes Lilian, after reverting only this comment is the addition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I don't understand how this makes sense, what does a comment have to do with the original issue?
In the issue, you mention:
This makes sense so I was expecting this PR to swap around these checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @liliankasem ... the fix which was mentioned throwing build error for some test cases, so we are fixing it and will remove the unnecessary comments in the next fix shortly