Skip to content

Conversation

@cadejacobson
Copy link
Contributor

@cadejacobson cadejacobson commented Oct 16, 2025

This PR better mirrors the behavior found on the real Wireserver for pulling KVP that is written to the guest OS.
Previously, the pipeline would output the final KVP file directly from the Azure-init container which contained more information than what would be read in the real POST to Wireserver.

Now, when Azure-init reports ready to the Wireserver, the mock server will access the shared KVP log directly and make a copy, storing it locally. Upon the completion of the pipeline, this copied file is now outputted, giving a more accurate reading of what Wireserver actually sees in the KVP file.

How to use

No usage, this is done automatically by the pipeline during each PR.

@cadejacobson cadejacobson changed the title Pull KVP on a post request [Not for Review] - Pull KVP on a post request Oct 16, 2025
@cadejacobson cadejacobson changed the title [Not for Review] - Pull KVP on a post request Pull KVP on a post request Oct 24, 2025
@cadejacobson cadejacobson marked this pull request as ready for review October 24, 2025 20:10
volumes:
- /sys/fs/cgroup:/sys/fs/cgroup:rw
- /run/dbus/system_bus_socket:/run/dbus/system_bus_socket:rw
- /tmp:/var/lib/hyperv:rw
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sharing all of /tmp seems a bit excessive for rw, I would probably suggest limiting to a particular directory specific for these tests (emptied prior to test)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like docker supports a tmpfs volume that should be perfect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When checking the Docker tmpfs documentation, it shows a limitation as not being able to share access across containers, as it is only available in one container. The two services here are run in different containers, so this will cause an issue when trying to pull the KVP logs from the mock server. I will update the code to have access to only a single /tmp/testinit/ folder, though, to avoid the braod /tmp/ access.

@cadejacobson cadejacobson requested a review from cjp256 October 27, 2025 19:58
Copy link
Contributor

@peytonr18 peytonr18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@cadejacobson cadejacobson merged commit 229761b into Azure:main Nov 5, 2025
8 checks passed
@cadejacobson cadejacobson deleted the cade/mount-kvp branch November 5, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants