-
Notifications
You must be signed in to change notification settings - Fork 14
Pull KVP on a post request #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1e7e061
Attempt to link a shared kvp pool
cadejacobson 6451b2f
Call log function
cadejacobson e5ad32c
Do not use external tag
cadejacobson 61eea04
Add self to the log kvp file
cadejacobson 00af9b3
Mount to a place that already exists
cadejacobson 4836a26
Test if the hyperv directory already exists
cadejacobson e3f0b34
Remove unnecessary calls
cadejacobson 4e23585
Output the correct kvp file
cadejacobson 94b8dd3
Update container name
cadejacobson 6fab435
Merge branch 'main' into cade/mount-kvp
cadejacobson 87e8cec
Merge branch 'main' into cade/mount-kvp
cadejacobson 0b2d016
Merge branch 'main' into cade/mount-kvp
cadejacobson e68994a
Error out if there is no KVP found
cadejacobson 10dc835
Remove cloudinit info from the file
cadejacobson 8047cb1
Use the pruned KVP file
cadejacobson e110653
Use quotes to ensure file exists
cadejacobson 53e2c7a
Add a comment for the perl command
cadejacobson a541010
Mount hyperv to tmp
cadejacobson 571a31e
Use a specific /tmp directory
cadejacobson 74e90e3
Merge branch 'main' into cade/mount-kvp
cadejacobson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sharing all of /tmp seems a bit excessive for rw, I would probably suggest limiting to a particular directory specific for these tests (emptied prior to test)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like docker supports a tmpfs volume that should be perfect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When checking the Docker tmpfs documentation, it shows a limitation as not being able to share access across containers, as it is only available in one container. The two services here are run in different containers, so this will cause an issue when trying to pull the KVP logs from the mock server. I will update the code to have access to only a single
/tmp/testinit/folder, though, to avoid the braod/tmp/access.