Update staging-lint-check workflow to block PR merge upon failure by AkhilaIlla · Pull Request #823 · Azure/azure-openapi-validator

AkhilaIlla · 2026-02-03T17:16:31Z

This PR improves the staging lint check workflow by adding merge-blocking capabilities, detecting linter rule source changes via the GitHub API, and simplifying rule selection to labels only.

.github/workflows/src/extract-rule-names-and-run-validation.js

mikeharder · 2026-02-21T00:04:26Z

@copilot: fix the linter error

Copilot · 2026-02-21T00:04:35Z

@mikeharder I've opened a new pull request, #828, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Updates the staging lint checks workflow to become merge-blocking, relying on PR labels for rule selection and using the GitHub API to detect when rule source files change.

Changes:

Make staging lint checks fail the workflow (and block merge) on command failures and on validation errors unless errors-acknowledged is present.
Detect linter rule source changes via pulls.listFiles and require test-<RuleName> labels when rule files change.
Remove PR-body-based rule selection and document the new gating/label behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
.github/workflows/test/runner.test.js	Updates tests to reflect removal of `FAIL_ON_ERRORS` env usage.
.github/workflows/test/extract-rule-names.test.js	Updates tests for label-only selection and adds coverage for new gating/detection helpers.
.github/workflows/staging-lint-checks.yaml	Updates workflow triggers/sparse checkout and switches to default export + passes `github` into the script.
.github/workflows/src/extract-rule-names-and-run-validation.js	Implements merge-blocking gates, rule-change detection via GitHub API, and label-only rule selection.
.github/workflows/README-staging-lint-checks.md	Documents the new merge-blocking gates and label-only usage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/staging-lint-checks.yaml

.github/workflows/src/extract-rule-names-and-run-validation.js

Copilot · 2026-02-21T00:08:56Z

.github/workflows/src/extract-rule-names-and-run-validation.js

+ * Blocking scenarios:
+ * 1. Command failures — AutoRest or script crashes
+ * 2. Validation errors without "errors-acknowledged" label
+ *


The numbering in the “Blocking scenarios” comment doesn’t match the numbering used in the code below (comment mentions scenarios 1–2, while the implementation refers to “Scenario 2” and “Scenario 3”). This makes the gating logic harder to follow.

Align the comment and the inline scenario labels so they refer to the same set of scenarios.

@copilot update the doc

* Initial plan * Remove unused hasLabel import to fix linter error Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>

Copilot · 2026-02-23T19:39:53Z

@mikeharder I've opened a new pull request, #829, to work on those changes. Once the pull request is ready, I'll request review from you.

mikeharder · 2026-02-23T19:40:55Z

@copilot: fix formatting

Copilot · 2026-02-23T19:41:04Z

@mikeharder I've opened a new pull request, #830, to work on those changes. Once the pull request is ready, I'll request review from you.

) * Initial plan * Add pull-requests: read permission to staging-lint-checks workflow Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>

* Initial plan * Fix prettier formatting in README and test file Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>

Copilot · 2026-02-24T20:34:42Z

@AkhilaIlla I've opened a new pull request, #831, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

AkhilaIlla · 2026-02-24T20:41:11Z

.github/workflows/staging-lint-checks.yaml

@copilot update the job name to match the workflow name

@copilot make this update in the same PR

Copilot · 2026-02-24T20:41:20Z

@AkhilaIlla I've opened a new pull request, #832, to work on those changes. Once the pull request is ready, I'll request review from you.

AkhilaIlla · 2026-02-24T20:47:20Z

.github/instructions/staging-lint-checks.instructions.md

@@ -11,37 +11,52 @@ merged into the main codebase.
 The workflow serves as a validation tool for linter rule development with the following workflow:


@copilot move this file to copilot instructions folder or the contributing.md
whereever it makes more sense for copilot to access it.

Copilot · 2026-02-24T20:47:30Z

@AkhilaIlla I've opened a new pull request, #833, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-24T20:54:17Z

@AkhilaIlla I've opened a new pull request, #834, to work on those changes. Once the pull request is ready, I'll request review from you.

Log the error for autorest failures

990716e

AkhilaIlla requested review from mikeharder, raosuhas, tejaswiMinnu and weshaggard as code owners February 3, 2026 17:16

AkhilaIlla added the test-MutabilityWithReadOnly label Feb 3, 2026

akhilailla added 2 commits February 3, 2026 12:13

Fix sparse checkout error

bd24ef2

Update staging-lint-check workflow to block PR merge upomn failure

795528e

AkhilaIlla changed the title ~~Log the error for Autorest failures in staging-lint-check pipeline~~ Update staging-lint-check workflow to block PR merge upon failure Feb 20, 2026

mikeharder reviewed Feb 21, 2026

View reviewed changes

.github/workflows/src/extract-rule-names-and-run-validation.js Show resolved Hide resolved

mikeharder requested a review from Copilot February 21, 2026 00:04

Copilot AI mentioned this pull request Feb 21, 2026

Fix unused import linter error in extract-rule-names test #828

Merged

Copilot started reviewing on behalf of mikeharder February 21, 2026 00:04 View session

Copilot AI reviewed Feb 21, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 23, 2026

Add pull-requests: read permission to staging-lint-checks workflow #829

Merged

Merge branch 'main' into akhilailla/test_test

ee2c2ae

Copilot AI mentioned this pull request Feb 23, 2026

Fix Prettier formatting in staging lint check workflow files #830

Merged

Copilot AI and others added 2 commits February 23, 2026 12:09

mikeharder approved these changes Feb 23, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 24, 2026

Fix scenario numbering mismatch in checkBlockingConditions #831

Draft

Apply suggestion from @Copilot

f55e1ef

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

AkhilaIlla commented Feb 24, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 24, 2026

Rename job to match workflow name in staging-lint-checks.yaml #832

Draft

AkhilaIlla commented Feb 24, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 24, 2026

Move staging lint checks README to CONTRIBUTING.md #833

Draft

Copilot AI mentioned this pull request Feb 24, 2026

Rename staging-lint-checks workflow job to match workflow name #834

Draft

akhilailla added 3 commits February 24, 2026 15:19

Merge main

309c0c0

Pull origin

89f4807

Minor updates

a5f13d2

mikeharder approved these changes Feb 24, 2026

View reviewed changes

		@@ -11,37 +11,52 @@ merged into the main codebase.
		The workflow serves as a validation tool for linter rule development with the following workflow:

Conversation

AkhilaIlla commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mikeharder commented Feb 21, 2026

Uh oh!

Copilot AI commented Feb 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

AkhilaIlla Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Feb 23, 2026

Uh oh!

mikeharder commented Feb 23, 2026

Uh oh!

Copilot AI commented Feb 23, 2026

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

AkhilaIlla Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

AkhilaIlla Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

AkhilaIlla Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

Copilot AI commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

AkhilaIlla commented Feb 3, 2026 •

edited

Loading