-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Review request for Microsoft.DBforPostgreSQL to add version stable/2025-08-01 #36219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review request for Microsoft.DBforPostgreSQL to add version stable/2025-08-01 #36219
Conversation
This comment is a remnant of a now-deprecated bot framework. It is being left behind only to point at the new comment that is updated by our new actions-based framework. |
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new API version preview/2025-08-01
for Microsoft.DBforPostgreSQL, adding comprehensive example files that demonstrate the enhanced capabilities of Azure Database for PostgreSQL flexible servers. The changes include updated examples for server management operations, new virtual endpoint features, enhanced security configurations, and advanced threat protection settings.
Key changes:
- Comprehensive server lifecycle management examples (create, update, delete, restart, start/stop)
- New virtual endpoint functionality for read/write load balancing
- Enhanced security features including Microsoft Entra ID authentication and data encryption
- Advanced threat protection settings configuration
- Improved server capabilities and operational examples
Reviewed Changes
Copilot reviewed 107 out of 109 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
VirtualNetworkSubnetUsage.json | Example for checking virtual network subnet usage for PostgreSQL servers |
VirtualEndpoints*.json | Examples for managing virtual endpoints including create, update, delete, get, and list operations |
ServerThreatProtectionSettings*.json | Examples for configuring and managing advanced threat protection settings |
ServerUpdate*.json | Various server update scenarios including Microsoft Entra authentication, data encryption, and maintenance windows |
ServerCreate*.json | Server creation examples with different configurations including geo-restore, replicas, and encryption |
Server*.json | Basic server operations like get, list, delete, start, stop, restart, and capabilities |
ReplicasListByServer.json | Example for listing read replicas of a PostgreSQL server |
PromoteReplicaAsPlannedSwitchover.json | Example for promoting a replica server as planned switchover |
ServerCapabilities.json | Comprehensive server capabilities information including supported SKUs and storage options |
...-manager/Microsoft.DBforPostgreSQL/stable/2025-08-01/examples/VirtualNetworkSubnetUsage.json
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,31 @@ | |||
{ | |||
"parameters": { | |||
"api-version": "2024-08-01", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The api-version in the example should be "2025-08-01" to match the directory structure, not "2024-08-01".
"api-version": "2024-08-01", | |
"api-version": "2025-08-01", |
Copilot uses AI. Check for mistakes.
@@ -0,0 +1,28 @@ | |||
{ | |||
"parameters": { | |||
"api-version": "2024-08-01", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The api-version should be "2025-08-01" to match the directory structure.
"api-version": "2024-08-01", | |
"api-version": "2025-08-01", |
Copilot uses AI. Check for mistakes.
...urce-manager/Microsoft.DBforPostgreSQL/stable/2025-08-01/examples/VirtualEndpointUpdate.json
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,22 @@ | |||
{ | |||
"parameters": { | |||
"api-version": "2024-08-01", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The api-version should be "2025-08-01" to match the directory structure.
"api-version": "2024-08-01", | |
"api-version": "2025-08-01", |
Copilot uses AI. Check for mistakes.
...urce-manager/Microsoft.DBforPostgreSQL/stable/2025-08-01/examples/VirtualEndpointCreate.json
Outdated
Show resolved
Hide resolved
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
Breaking changes previously reviewed and approved in #33028 |
...manager/Microsoft.DBforPostgreSQL/stable/2025-08-01/examples/CapabilitiesByLocationList.json
Outdated
Show resolved
Hide resolved
...e-manager/Microsoft.DBforPostgreSQL/stable/2025-08-01/examples/CapabilitiesByServerList.json
Show resolved
Hide resolved
...source-manager/Microsoft.DBforPostgreSQL/stable/2025-08-01/AdministratorsMicrosoftEntra.json
Show resolved
Hide resolved
could you update |
We've recently published a preview version of our API (2025-06-01-preview) for which we didn't do this either. Should I open another PR to add that version to this file? Thanks! |
|
...ication/postgresql/resource-manager/Microsoft.DBforPostgreSQL/stable/2025-08-01/Servers.json
Show resolved
Hide resolved
@live1206 @msyyc we're not sure why this PR is having issue with SDK validation for .NET and Python. Our previous PR doesn't have these issues: https://github.com/Azure/azure-rest-api-specs/pull/35537/checks |
/azp run SDK Validation - Python |
Azure Pipelines successfully started running 1 pipeline(s). |
@mattboentoro python failure is fixed. |
The .NET SDK validation failure is due to breaking changes, custom SDK code in azure-sdk-for-net is incompatible with latest generate .NET SDK. We can only fix it in azure-sdk-for-net when generate new version .NET SDK. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.