-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Migrate PostgreSql to TypeSpec #36556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
specification/postgresql/DBforPostgreSQL.Management/AdministratorMicrosoftEntra.tsp
Outdated
Show resolved
Hide resolved
specification/postgresql/DBforPostgreSQL.Management/BackupAutomaticAndOnDemand.tsp
Outdated
Show resolved
Hide resolved
specification/postgresql/DBforPostgreSQL.Management/Configuration.tsp
Outdated
Show resolved
Hide resolved
Hi @mcgallan , we are currently planning to release a stable swagger in the next coming weeks. Should we have this migration based off what will soon be the newest version out? #36219 @mattboentoro for awareness |
@mattboentoro @nachoalonsoportillo These issues were brought up in start of PR of causing conflicts: 2.supportedHaMode has the same issue as recommendationType - there are duplicate enum names with different values that TypeSpec treats as the same enum during generation, causing conflicts. 3.the original swagger used the "x-ms-visibility": "internal" syntax, which doesn't have a corresponding syntax in TypeSpec. 4.the secret property in BackupStoreDetails is incorrectly placed within the items property, which is not the correct syntax. 5.threatProtectionName is an enum type, and when it's used as a parameter in the path, it cannot have a pattern added to it. 6.In TypeSpec, we cannot add a default value of null for model properties. |
This PR migrates your latest version (identified by the tag in your readme.md) of swagger to TypeSpec. We already tried our best to make sure the TypeSpec represents same as previous swagger. Since we lack the business knowledge, please validate this PR again to make sure it's functional equivalent as before. The local validation step is at Getting started | TypeSpec Azure
Besides, TypeSpec encourages to follow ARM guidelines. Therefore, some representations in your previous swagger needs to be fixed. Please handle all these issues properly and them contact Azure SDK Team:
1.You're identifying that the TuningOptions_ListRecommendations operation uses an enum named recommendationType, which has the same name as another existing enum, but they contain different values. TypeSpec will treat them as the same enum during generation, which causes errors.
2.supportedHaMode has the same issue as recommendationType - there are duplicate enum names with different values that TypeSpec treats as the same enum during generation, causing conflicts.
3.the original swagger used the "x-ms-visibility": "internal" syntax, which doesn't have a corresponding syntax in TypeSpec.
4.the secret property in BackupStoreDetails is incorrectly placed within the items property, which is not the correct syntax.
5.threatProtectionName is an enum type, and when it's used as a parameter in the path, it cannot have a pattern added to it.
6.In TypeSpec, we cannot add a default value of null for model properties.
Please reach out to TypeSpec Discussions Channel if there is any help needed.