-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Migrate trafficmanager TypeSpec #37328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
209c4d4
to
ec27915
Compare
05f4a4b
to
ffa4f81
Compare
d574a16
to
2e08069
Compare
@pshao25 |
3dae52b
to
3fb0f7e
Compare
Don't recommend anything before you get into the root cause of the pipeline failures. In your case, the pipeline failed because its original resource's type property is not |
a44d33a
to
48d5ac9
Compare
6e48e4d
to
2ac729e
Compare
a68d2d9
to
2ac729e
Compare
This PR migrates your latest version (identified by the tag in your readme.md) of swagger to TypeSpec. We already tried our best to make sure the TypeSpec represents same as previous swagger. Since we lack the business knowledge, please validate this PR again to make sure it's functional equivalent as before. The local validation step is at Getting started | TypeSpec Azure
Besides, TypeSpec encourages to follow ARM guidelines. Therefore, some representations in your previous swagger will be fixed to follow these guidelines. When you see differences in your local validation, please keep this note in mind. Here is the list you need to pay attention:
Please reach out to TypeSpec Discussions Channel if there is any help needed.