Skip to content

Don't remove RPaaSException from summarize-checks #37874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 1, 2025
Merged

Don't remove RPaaSException from summarize-checks #37874

merged 5 commits into from
Oct 1, 2025

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Oct 1, 2025 •
edited by mikeharder
Loading

verification: mikeharder#53

Before PR

image

Removal of RPaaSException label was the bug

After PR

image image

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@scbedd scbedd moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🍔🌭 Oct 1, 2025
scbedd
scbedd commented Oct 1, 2025
View reviewed changes
@mikeharder mikeharder mentioned this pull request Oct 1, 2025
Closed
mikeharder
mikeharder reviewed Oct 1, 2025
View reviewed changes
mikeharder
mikeharder approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending rename of test case

mikeharder
mikeharder requested changes Oct 1, 2025
View reviewed changes
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking until I verify with e2e test in my fork

mikeharder
mikeharder approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@mikeharder mikeharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, pending rename of test case (if you agree)

@scbedd scbedd merged commit 8c87aeb into main Oct 1, 2025
50 of 54 checks passed
@scbedd scbedd deleted the fix-rpaasException-setting branch October 1, 2025 18:10
@mikeharder mikeharder removed their assignment Oct 1, 2025
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🍔🌭 Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeharder mikeharder mikeharder approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

Assignees

@scbedd scbedd

Labels
None yet
Projects
Azure SDK EngSys 🍔🌭
Status: 🎊 Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[summarize-checks] label RPaaSException cannot be used to override label CI-NewRPNamespaceWithoutRPaaS
2 participants
@scbedd @mikeharder