Skip to content

Don't remove RPaaSException from summarize-checks #37874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 1, 2025
Merged

Don't remove RPaaSException from summarize-checks #37874

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a062454
start progression on not setting RPaaSException label
scbedd Oct 1, 2025
b52f49a
remove rpassExceptionRequired from impactAssessment
scbedd Oct 1, 2025
111b27a
additional tests, updates to formatting, a couple other removals from…
scbedd Oct 1, 2025
aff7942
Merge branch 'main' into fix-rpaasException-setting
mikeharder Oct 1, 2025
050af58
Update .github/workflows/test/summarize-checks/summarize-checks.test.js
scbedd Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/src/summarize-checks/labelling.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/*
This file covers two areas of enforcement:
1. It calculates what set of label rules has been violated by the current PR, for the purposes of updating next steps to merge.
Expand Down Expand Up @@ -506,7 +506,7 @@
ciNewRPNamespaceWithoutRpaaSLabel.shouldBePresent = impactAssessment.rpaasRPMissing || false;

const rpaasExceptionLabel = new Label("RPaaSException", labelContext.present);
rpaasExceptionLabel.shouldBePresent = impactAssessment.rpaasExceptionRequired || false;
rpaasExceptionLabel.shouldBePresent = ("RPaaSException" in labelContext.present)

const ciRpaasRPNotInPrivateRepoLabel = new Label(
"CI-RpaaSRPNotInPrivateRepo",
Expand Down Expand Up @@ -541,7 +541,7 @@
labelContext,
armReviewLabel.shouldBePresent,
impactAssessment.rpaasRPMissing,
impactAssessment.rpaasExceptionRequired,
rpaasExceptionLabel.shouldBePresent,
impactAssessment.rpaasRpNotInPrivateRepo,
);
}
Expand All @@ -555,7 +555,6 @@
rpassReviewRequiredLabel.applyStateChange(labelContext.toAdd, labelContext.toRemove);
newRPNamespaceLabel.applyStateChange(labelContext.toAdd, labelContext.toRemove);
ciNewRPNamespaceWithoutRpaaSLabel.applyStateChange(labelContext.toAdd, labelContext.toRemove);
rpaasExceptionLabel.applyStateChange(labelContext.toAdd, labelContext.toRemove);
ciRpaasRPNotInPrivateRepoLabel.applyStateChange(labelContext.toAdd, labelContext.toRemove);

// this is the only labelling that was part of original pipelinebot logic, it handles the rotation of
Expand Down
Loading