[DEV] [Cherry-pick September Hotfix] Don't set browser pkg name in CustomTabIntent, Fixes AB#3396027 #2780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
There was a problem hiding this comment.
Pull Request Overview
Removes setting the browser package name on the Custom Tabs intent while preserving it for plain ACTION_VIEW fallback intents.
- Adds setPackage only when constructing a fresh ACTION_VIEW intent (fallback paths)
- Removes the unconditional setPackage that previously also affected the CustomTab intent
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ain/java/com/microsoft/identity/common/internal/ui/browser/BrowserAuthorizationStrategy.java
Show resolved
Hide resolved
...ain/java/com/microsoft/identity/common/internal/ui/browser/BrowserAuthorizationStrategy.java
Show resolved
Hide resolved
shahzaibj
changed the title
github-actions
bot
changed the title
melissaahn
approved these changes
Oct 9, 2025
changelog.txt
Outdated
| - [MINOR] SDK now handles SMS as strong authentication method #2766 | ||
| - [MINOR] Added error handling when webcp redirects have browser protocol #2767 | ||
| - [PATCH] Fix for app link redirect from CCT due to forced browser preference (#2775) | ||
| - [PATCH] Don't set browser pkg name in CustomTabIntent (#2780) |
There was a problem hiding this comment.
I'm not sure if the hotfix resulted in a new common version, so disregard if not relevant, but I would think that maybe this change would be under the hotfix version?
melissaahn
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#3396027