Skip to content

[DEV] [Cherry-pick September Hotfix] Don't set browser pkg name in CustomTabIntent, Fixes AB#3396027 #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2025
Merged

[DEV] [Cherry-pick September Hotfix] Don't set browser pkg name in CustomTabIntent, Fixes AB#3396027 #2780

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
030d6bd
Don't set browser pkg name in CustomTabIntent
shahzaibj Oct 2, 2025
0e10a2a
Update changelog.txt
shahzaibj Oct 8, 2025
5b7bae6
Update changelog.txt
shahzaibj Oct 9, 2025
d578ac8
Update changelog.txt
shahzaibj Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ vNext
- [MINOR] SDK now handles SMS as strong authentication method #2766
- [MINOR] Added error handling when webcp redirects have browser protocol #2767
- [PATCH] Fix for app link redirect from CCT due to forced browser preference (#2775)
- [PATCH] Don't set browser pkg name in CustomTabIntent (#2780)
Copy link
Contributor

@melissaahn melissaahn Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the hotfix resulted in a new common version, so disregard if not relevant, but I would think that maybe this change would be under the hotfix version?


Version 22.1.0
----------
Expand Down
3 changes: 2 additions & 1 deletion .../java/com/microsoft/identity/common/internal/ui/browser/BrowserAuthorizationStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ public Future<AuthorizationResult> requestAuthorization(
if (!mCustomTabManager.bind(context, mBrowser.getPackageName())) {
//create browser auth intent
authIntent = new Intent(Intent.ACTION_VIEW);
authIntent.setPackage(mBrowser.getPackageName());
} else {
authIntent = mCustomTabManager.getCustomTabsIntent().intent;
}
Expand All @@ -109,9 +110,9 @@ public Future<AuthorizationResult> requestAuthorization(
);
//create browser auth intent
authIntent = new Intent(Intent.ACTION_VIEW);
authIntent.setPackage(mBrowser.getPackageName());
}

authIntent.setPackage(mBrowser.getPackageName());
final URI requestUrl = authorizationRequest.getAuthorizationRequestAsHttpRequest();

authIntent.setData(Uri.parse(requestUrl.toString()));
Expand Down
Loading