fix: CSV extenstion uses invariant culture #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for specifying culture info for csv reader and writer.
philnach
requested changes
Jan 22, 2025
Extensions/Csv/Cosmos.DataTransfer.CsvExtension/Settings/CsvWriterSettings.cs
Outdated
Show resolved
Hide resolved
- Added `IValidatableObject` to `CsvWriterSettings`. - Updated Culture to accept both `Invariant`/`Current` and `InvariantCulture`/`CurrentCulture`. - Specified only the latter in README. - Added unit testing for `CsvWriterSettings`.
philnach
approved these changes
Jan 24, 2025
Collaborator
philnach
left a comment
philnach
left a comment
There was a problem hiding this comment.
Looks great, thank you for adding unit tests as well. @bowencode can you take a look at this PR?
bowencode
previously approved these changes
Feb 10, 2025
bowencode
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
Added support for specifying culture info for csv writer.