-
Notifications
You must be signed in to change notification settings - Fork 67
fix: CSV extenstion uses invariant culture #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a9aa572
fix: Csv uses invariant culture
stefanedwards 7374087
fix: Changes requested
stefanedwards ca4fca3
Fixing broken test
bowencode 70eae7a
Merge branch 'main' into fix-csv-culture
bowencode 1cf1329
Merge branch 'main' into fix-csv-culture
bowencode 23be84e
Fixing tests and associated code
bowencode 5fa1f18
Change to environment dependent test to skip in build environment
bowencode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 11 additions & 1 deletion
12
Extensions/Csv/Cosmos.DataTransfer.CsvExtension/Settings/CsvWriterSettings.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,19 @@ | ||
| using Cosmos.DataTransfer.Interfaces; | ||
| using System.Globalization; | ||
| using Cosmos.DataTransfer.Interfaces; | ||
|
|
||
| namespace Cosmos.DataTransfer.CsvExtension.Settings; | ||
|
|
||
| public class CsvWriterSettings : IDataExtensionSettings | ||
| { | ||
| public bool IncludeHeader { get; set; } = true; | ||
| public string Delimiter { get; set; } = ","; | ||
| public string Culture { get; set; } = "InvariantCulture"; | ||
| public CultureInfo GetCultureInfo() { | ||
| switch (this.Culture.ToLower()) | ||
| { | ||
| case "invariantculture": return CultureInfo.InvariantCulture; | ||
| case "current": return CultureInfo.CurrentCulture; | ||
| default: return CultureInfo.GetCultureInfo(this.Culture); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.