Update all projects to .NET 8 framework and many Nuget refs to recent packages #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philnach
requested changes
Feb 10, 2025
Collaborator
philnach
left a comment
philnach
left a comment
There was a problem hiding this comment.
Change looks good to me, I confirmed I was able to build successfully locally.
I see you are picking up the new patched version of NewtonSoft JSON in this change. #160 also updated System.Text.Json to version 8.05 to address the CVE in that component as well. Looking at the NuGets in this change System.Text.Json isn't on a consistent version:
Can you update that as well and we can close #158 & #159, with this change?
philnach
approved these changes
Feb 11, 2025
Collaborator
philnach
left a comment
philnach
left a comment
There was a problem hiding this comment.
Thanks, I confirmed project still builds and all the System.Text.Json all point to 8.0.5 now :)
joelhulen
approved these changes
Feb 13, 2025
markjbrown
approved these changes
Feb 13, 2025
This was referenced Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.