perf(router): remove unnecessary dict copy in completion hot paths #15613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary deployment['litellm_params'].copy() in _completion and _acompletion functions. The dict is only read and spread into a new dict, never modified, making the defensive copy wasteful. Changes: - Remove .copy() in _completion (sync hot path) - Remove .copy() in _acompletion (async hot path) Impact: - Every completion request (highest traffic endpoints) - Eliminates unnecessary dict allocation and copy on every call - Dict spreading already creates new dict, so no mutation possible Test coverage: - Added tests verifying deployment params unchanged after calls - Tests both sync and async completion paths - Validates optimization doesn't introduce mutations
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…com/BerriAI/litellm into litellm_replace_shallow_copy
AlexsanderHamir
merged commit 145b864
into
litellm_october_alexsander_stanging
37 of 42 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
perf(router): remove unnecessary dict copy in completion hot paths
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🧹 Refactoring
Changes
Test Results