-
Notifications
You must be signed in to change notification settings - Fork 336
hellovai/beps/exceptions #2759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hellovai
wants to merge
22
commits into
canary
Choose a base branch
from
hellovai/beps/exceptions
base: canary
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
hellovai/beps/exceptions #2759
Changes from 11 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
9ceed11
Initial research
hellovai f0cb411
Adding readme
hellovai 75ba816
upate readme
hellovai 7863ce6
add more comparisons (try-catch, go2 proposal)
hellovai 80c29dc
adding ambiguity of open questions
hellovai 2285593
add an updates section on the doc
hellovai 0067ef1
add match statement as well
hellovai 17d376d
update readme
hellovai 62dd494
better ideas for catch
hellovai 0a77b82
update readme
hellovai dc6877b
add coloring semantics
hellovai 8e92cff
adding story basis
hellovai 967761a
updating beps
hellovai fee6552
update readme
hellovai f846bc3
updating statuses
hellovai 9caba6c
improvements to content
hellovai fda19f5
updated readme
hellovai 3ea9af2
update bep?
hellovai 924d786
improve beps
hellovai 32ad26f
add slack notification
hellovai 9d221e0
fix
hellovai cd9a6cd
fixes for top level things
hellovai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
|
|
||
| import sys | ||
| import os | ||
| from pathlib import Path | ||
|
|
||
| # Add current dir to path to import bep_hooks | ||
| sys.path.append(os.getcwd()) | ||
| import bep_hooks | ||
|
|
||
| # Mock Page object | ||
| class MockFile: | ||
| def __init__(self, src_path): | ||
| self.src_path = src_path | ||
|
|
||
| class MockPage: | ||
| def __init__(self, src_path): | ||
| self.file = MockFile(src_path) | ||
|
|
||
| # Read the actual file content | ||
| file_path = Path("docs/proposals/BEP-001-exceptions/context/go.md") | ||
| with open(file_path, "r") as f: | ||
| markdown = f.read() | ||
|
|
||
| print(f"Original Markdown Length: {len(markdown)}") | ||
|
|
||
| # Run the hook | ||
| try: | ||
| result = bep_hooks.on_page_markdown(markdown, MockPage("proposals/BEP-001-exceptions/context/go.md")) | ||
| print(f"Result Markdown Length: {len(result)}") | ||
| print("--- RESULT START ---") | ||
| print(result[:500]) # Print first 500 chars | ||
| print("--- RESULT END ---") | ||
| print("--- RESULT TAIL ---") | ||
| print(result[-500:]) | ||
| print("--- RESULT TAIL END ---") | ||
|
|
||
| if len(result) == 0: | ||
| print("ERROR: Result is empty!") | ||
| except Exception as e: | ||
| print(f"ERROR: Hook failed with {e}") | ||
| import traceback | ||
| traceback.print_exc() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,10 @@ Below is an auto-generated index of all BEPs. | |
| </thead> | ||
| <tbody> | ||
| <tr> | ||
| <td><a href="./proposals/BEP-001-exceptions/README.md"><strong>BEP-001</strong>: Exceptions</a> <img src="https://img.shields.io/badge/Status-Draft-lightgrey" alt="Draft"><br><br>This is a placeholder for the Exceptions design proposal.<br><br><span style='font-size:0.8em; color:gray'>Shepherd(s): Vaibhav Gupta <[email protected]> | Created: 2025-11-20 | Updated: 2025-11-28</span></td> | ||
| <td><a href="./proposals/BEP-001-exceptions/README.md"><strong>BEP-001</strong>: Exception Handling</a> <img src="https://img.shields.io/badge/Status-Draft-lightgrey" alt="Draft"><br><br><br><br><span style='font-size:0.8em; color:gray'>Shepherd(s): Vaibhav Gupta <[email protected]> | Created: 2025-11-20 | Updated: 2025-12-02</span></td> | ||
| </tr> | ||
| <tr> | ||
| <td><a href="./proposals/BEP-002-match/README.md"><strong>BEP-002</strong>: match</a> <img src="https://img.shields.io/badge/Status-Draft-lightgrey" alt="Draft"><br><br><br><br><span style='font-size:0.8em; color:gray'>Shepherd(s): hellovai <[email protected]> | Created: 2025-12-01 | Updated: 2025-12-01</span></td> | ||
| </tr> | ||
| </tbody> | ||
| </table> | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Debug script references deleted file path
This debug script references
docs/proposals/BEP-001-exceptions/context/go.md, but this file was deleted in the same commit. The script will crash withFileNotFoundErrorwhen executed. This appears to be a development debugging tool that was accidentally committed alongside the production code changes.