hellovai/beps/exceptions #2759

hellovai · 2025-12-01T18:32:29Z

Initial research
Adding readme

Note

Adds comprehensive BEP-001/002 docs, introduces MkDocs diff/TOC/nav enhancements, and updates CI to send Slack notifications with canary-aware indexing.

Docs:
- BEP-001: Exception Handling: New proposal with background, syntax, guides, alternatives, tooling, and TypeScript deviations.
- BEP-002: match: New proposal and context docs; README index updated to list both BEPs.
MkDocs Hooks/UI:
- Auto-generates TOCs, highlights inline diffs vs canary and recent commits, adds nav change indicators, and a compare dropdown with summaries.
CI/Workflows:
- Fetches canary explicitly and posts Slack notifications for canary and preview deployments using generated payloads.
Scripts/Automation:
- summarize_changes.py: Summarizes BEP deltas and builds Slack Block Kit payloads.
- update_bep_readme.py: Canary-aware dates, TBD handling, stricter metadata; regenerates README table.
Config/Dev:
- MkDocs config tweaks; add debug hook; update mise.toml (Node 22, tools).

^{Written by Cursor Bugbot for commit cd9a6cd. This will update automatically on new commits. Configure here.}

vercel · 2025-12-01T18:32:34Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
promptfiddle	Ready	Preview	Comment	Dec 5, 2025 0:18am

github-actions · 2025-12-01T18:36:47Z

✅ Latest build complete • View logs

github-actions · 2025-12-01T18:37:08Z

🐑 BEPs Preview Ready

Preview URL: https://dj7ggjkp4tlhz.cloudfront.net/hellovai-beps-exceptions/

_{Commit: 75ba8164eaa1db7464df3b8798c6271b5ab07577 • Workflow run}

github-actions · 2025-12-01T22:44:00Z

🐑 BEPs Preview Ready

Preview URL: https://dj7ggjkp4tlhz.cloudfront.net/hellovai-beps-exceptions/

_{Commit: 7863ce626985b72df6c3e77b9cb20fc4042ea5b3 • Workflow run}

github-actions · 2025-12-01T23:26:12Z

🐑 BEPs Preview Ready

Preview URL: https://dj7ggjkp4tlhz.cloudfront.net/hellovai-beps-exceptions/

_{Commit: 80c29dcce45ce6f4fc88290e1d54b65b0d9d3013 • Workflow run}

github-actions · 2025-12-02T00:46:46Z

🐑 BEPs Preview Ready

Preview URL: https://dj7ggjkp4tlhz.cloudfront.net/hellovai-beps-exceptions/

_{Commit: 2285593eeaa5025033cb2133e8a588dc00452748 • Workflow run}

github-actions · 2025-12-02T07:49:35Z

🐑 BEPs Preview Ready

Preview URL: https://dj7ggjkp4tlhz.cloudfront.net/hellovai-beps-exceptions/

_{Commit: 17d376d965071b83ea6f158b7b1863310f09cadb • Workflow run}

cursor

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

cursor · 2025-12-02T07:53:15Z

beps/bep_hooks.py

+            is_safe = False
+        elif stripped.startswith('- ') or stripped.startswith('* ') or stripped.startswith('+ '): # Unordered list
+            is_safe = False
+        elif stripped[0].isdigit() and '. ' in stripped[:5]: # Ordered list (heuristic)


Bug: Missing empty string guard causes potential IndexError

The code accesses stripped[0] without checking if stripped is non-empty, which can raise an IndexError. This happens when a line contains only Unicode whitespace characters (like non-breaking space \u00A0) that aren't regular space or tab - such lines pass the not line and line.startswith(' ') checks, but strip() results in an empty string. The similar check at line 247 correctly guards with next_stripped and next_stripped[0].isdigit(), but line 210 is missing this guard.

cursor · 2025-12-02T07:53:15Z

beps/bep_hooks.py

+            pass
+        else:
+            # Context line (starts with space)
+            current_new_line += 1


Bug: Diff parser mishandles "No newline" markers causing offset

The else branch in _parse_unified_diff assumes any unmatched line is a context line and increments current_new_line. However, unified diffs can contain \ No newline at end of file markers that start with \, not space. These markers are not actual lines in the file, so incrementing the counter for them causes all subsequent line numbers to be off by one. The code comment says "Context line (starts with space)" but doesn't actually check for that prefix.

github-actions · 2025-12-03T02:40:09Z

🐑 BEPs Preview Ready

Preview URL: https://dj7ggjkp4tlhz.cloudfront.net/hellovai-beps-exceptions/

_{Commit: 0a77b82b757d5775d9c8901ba7d251efb4a85ac2 • Workflow run}

github-actions · 2025-12-03T16:33:20Z

🐑 BEPs Preview Ready

Preview URL: https://dj7ggjkp4tlhz.cloudfront.net/hellovai-beps-exceptions/

_{Commit: dc6877bf671d6479a79e9f35b6211d04827c4264 • Workflow run}

cursor · 2025-12-03T16:38:58Z

beps/bep_hooks.py

    summaries = []
    # Canary Summary
-    c_canary = len(parsed_canary["added"]) + len(parsed_canary["removed"])
+    c_canary = len(parsed_canary)


Bug: Missing HTML escaping for commit subjects in output

Commit subjects from c['subject'] are inserted directly into HTML option elements without escaping. If a commit message contains characters like <, >, &, or ", this could produce malformed HTML output that breaks the dropdown rendering. The previous code only used static option labels without commit subjects, so this is a new issue introduced by this change.

github-actions · 2025-12-03T21:37:11Z

🐑 BEPs Preview Ready

Preview URL: https://dj7ggjkp4tlhz.cloudfront.net/hellovai-beps-exceptions/

_{Commit: 8e92cff51b0183da9930af103df03f6990018ccc • Workflow run}

cursor · 2025-12-04T16:04:27Z

beps/debug_hook.py

+
+# Read the actual file content
+file_path = Path("docs/proposals/BEP-001-exceptions/context/go.md")
+with open(file_path, "r") as f:


Bug: Debug script references deleted file path

This debug script references docs/proposals/BEP-001-exceptions/context/go.md, but this file was deleted in the same commit. The script will crash with FileNotFoundError when executed. This appears to be a development debugging tool that was accidentally committed alongside the production code changes.

github-actions · 2025-12-04T16:08:32Z

🐑 BEPs Preview Ready

Preview URL: https://dj7ggjkp4tlhz.cloudfront.net/hellovai-beps-exceptions/

_{Commit: fee6552326f4732686930f4a0538e2d198af3d7a • Workflow run}

github-actions · 2025-12-04T23:26:46Z

🐑 BEPs Preview Ready

Preview URL: https://dj7ggjkp4tlhz.cloudfront.net/hellovai-beps-exceptions/

_{Commit: 3ea9af24d70d47a27ba427fcaaf6f2cb90c1b693 • Workflow run}

github-actions · 2025-12-04T23:30:36Z

🐑 BEPs Preview Ready

Preview URL: https://dj7ggjkp4tlhz.cloudfront.net/hellovai-beps-exceptions/

_{Commit: 924d7867b4de2a8ad9705ed48da055125498d39d • Workflow run}

cursor · 2025-12-04T23:34:55Z

.github/workflows/beps.reusable.yaml

-      - name: Fetch base branch history
-        run: |
-          git fetch --depth=500 origin canary
+      - name: Fetch canary ref


Bug: Shallow clone breaks git history lookup in check script

The removal of fetch-depth: 0 from the check-beps job causes a shallow clone (depth 1 by default). The update_bep_readme.py --check script runs git log {canary_ref}..HEAD to determine file modification dates, which requires commit history between canary and HEAD. With a shallow clone, this history is unavailable, causing the script to incorrectly return "TBD" for last_modified dates instead of actual values, leading to potential check failures or inconsistent behavior between CI and local development.

.github/workflows/beps.reusable.yaml

          env: beps-canary

+      - name: Install uv
+        uses: astral-sh/setup-uv@v5


.github/workflows/beps.reusable.yaml

+        run: git fetch origin canary
+
+      - name: Install uv
+        uses: astral-sh/setup-uv@v5


github-actions · 2025-12-04T23:47:28Z

🐑 BEPs Preview Ready

Preview URL: https://dj7ggjkp4tlhz.cloudfront.net/hellovai-beps-exceptions/

_{Commit: 9d221e085f4ff604c9915183fda82474a73297c6 • Workflow run}

github-actions · 2025-12-05T00:03:10Z

🐑 BEPs Preview Ready

Preview URL: https://dj7ggjkp4tlhz.cloudfront.net/hellovai-beps-exceptions/

_{Commit: cd9a6cdd36a829ef11b1a16b9f4d80bcd9023809 • Workflow run}

hellovai added 2 commits November 30, 2025 09:12

Initial research

9ceed11

Adding readme

f0cb411

upate readme

75ba816

vercel bot deployed to Preview December 1, 2025 18:52 View deployment

add more comparisons (try-catch, go2 proposal)

7863ce6

vercel bot deployed to Preview December 1, 2025 23:00 View deployment

adding ambiguity of open questions

80c29dc

vercel bot deployed to Preview December 1, 2025 23:41 View deployment

add an updates section on the doc

2285593

vercel bot deployed to Preview December 2, 2025 01:03 View deployment

hellovai added 2 commits December 1, 2025 23:46

add match statement as well

0067ef1

update readme

17d376d

cursor bot reviewed Dec 2, 2025

View reviewed changes

vercel bot deployed to Preview December 2, 2025 08:03 View deployment

hellovai added 2 commits December 2, 2025 18:33

better ideas for catch

62dd494

update readme

0a77b82

vercel bot deployed to Preview December 3, 2025 02:55 View deployment

add coloring semantics

dc6877b

cursor bot reviewed Dec 3, 2025

View reviewed changes

vercel bot deployed to Preview December 3, 2025 16:48 View deployment

adding story basis

8e92cff

vercel bot deployed to Preview December 3, 2025 21:52 View deployment

updating beps

967761a

cursor bot reviewed Dec 4, 2025

View reviewed changes

update readme

fee6552

updating statuses

f846bc3

vercel bot deployed to Preview December 4, 2025 16:41 View deployment

hellovai added 3 commits December 4, 2025 15:16

improvements to content

9caba6c

updated readme

fda19f5

update bep?

3ea9af2

improve beps

924d786

cursor bot reviewed Dec 4, 2025

View reviewed changes

add slack notification

32ad26f

github-advanced-security bot found potential problems Dec 4, 2025

View reviewed changes

fix

9d221e0

fixes for top level things

cd9a6cd

vercel bot deployed to Preview December 5, 2025 00:18 View deployment

hellovai/beps/exceptions #2759

Are you sure you want to change the base?

hellovai/beps/exceptions #2759

Uh oh!

Conversation

hellovai commented Dec 1, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

This PR is being reviewed by Cursor Bugbot

Uh oh!

cursor bot Dec 2, 2025

Choose a reason for hiding this comment

Bug: Missing empty string guard causes potential IndexError

Uh oh!

cursor bot Dec 2, 2025

Choose a reason for hiding this comment

Bug: Diff parser mishandles "No newline" markers causing offset

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

cursor bot Dec 3, 2025

Choose a reason for hiding this comment

Bug: Missing HTML escaping for commit subjects in output

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

cursor bot Dec 4, 2025

Choose a reason for hiding this comment

Bug: Debug script references deleted file path

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

cursor bot Dec 4, 2025

Choose a reason for hiding this comment

Bug: Shallow clone breaks git history lookup in check script

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

github-actions bot commented Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hellovai commented Dec 1, 2025 •

edited by cursor bot

Loading

vercel bot commented Dec 1, 2025 •

edited

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading