Skip to content

Conversation

wr1159
Copy link

@wr1159 wr1159 commented Sep 24, 2024

Resolves #55
GetAllQuestions endpoint to now take in optional search param

@wr1159 wr1159 self-assigned this Sep 24, 2024
Copy link

@SelwynAng SelwynAng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall but error is thrown upon running yarn build.
Screenshot 2024-09-26 at 12 02 20 PM

import LoadingScreen from "@/components/common/loading-screen";
import { useRouter } from "next/navigation";
import { useRouter, useSearchParams } from "next/navigation";
import QuestionFilter from "./question-filter";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use absolute import statement

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 357711e

@SelwynAng SelwynAng mentioned this pull request Sep 26, 2024
@SelwynAng SelwynAng merged commit 91e03a8 into main Sep 27, 2024
2 checks passed
@SelwynAng SelwynAng deleted the feature/question-service/search-questions branch September 27, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

F2.2.6 The service should allow a search of specific questions by name.

2 participants