-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Warn abstract non inherit, fix seeds & ammo #83018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Warn abstract non inherit, fix seeds & ammo #83018
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather fix inheritance and extend/delete, but that looks complex, and just warning about it is fine.
Mod stuff should be fixed also, otherwise CI do not pass |
Thanks for the heads up. I've just given up on checking tests since the always fail for irrelevant reasons (some icecream stuff for instance). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @LyleSY
Ah, great. The test suit gives up after inheritance errors have been reported for one mod, so this will apparently be a one mod-failure-fix that-next mod failure exercise. |
Need to resolve a conflict |
Summary
None
Purpose of change
Edit: Additions
Describe the solution
See purpose.
Describe alternatives you've considered
Testing
Additional context
Looked at all the usages of the ammo_cartridge recipe to verify the qualities are copied into all of them.
There was some weird stuff among the warnings, as well as things that might warrant a further look: