Implement guns being able to have flashlights, add one #83061
+141
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
GuardianDll
force-pushed
the
mounted_gun_flashlights
branch
2 times, most recently
from
ed82bb9 to
3215ea5
Compare
GuardianDll
force-pushed
the
mounted_gun_flashlights
branch
from
3215ea5 to
8e2f6b2
Compare
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Underbarrel flashlights or something"
Purpose of change
Open the road for #67595
Also because it's cool
Describe the solution
Make MOD pockets transparent, make the game process the items inside MOD pockets (so it can properly consume charges and deactivate), allow some gunmods to be shown in inventory (so you can activate/deactivate it plus reload it)
Issues
At this moment gunmods list all the use actions they have, which means installed flashlight would still have "install gunmod" shown in it's action list. No bueno(it doesn't allow you to install the mod that is already installed, it's purely a visual bug i would assume)resolvedTesting
Additional context
I suspect the infrastructure added would allow stuff like thermal scopes and similar also? need to check itit seems additional enchantment support needs to be added first