Skip to content

Conversation

@Inglonias
Copy link
Contributor

Summary

Balance "Drastically nerf the value of fiction books"

Purpose of change

I think it's a little silly that I can sell three novels for a gun at the refugee center, and it depends which novels they are.

Describe the solution

All fiction books have a barter value of 50 cents for paperback or 1 dollar for hardcover.

Describe alternatives you've considered

I tried making this into a mod instead, but the number of dependencies and snippets in the book section makes this infeasible. If someone better at JSON-fu than I am can make a mod for this instead, I would also accept that.

Testing

Tested in my personal install. It seems to work.

Additional context

If this is not wanted, I would appreciate some help with modding this. It looks like just modding the abstract does not work.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Nov 17, 2025
@RenechCDDA
Copy link
Member

These prices seem too low for the pricing guide

@Inglonias
Copy link
Contributor Author

I would argue that novels and other fiction books are pretty common and have limited use - If your only objection is the number itself, I would be willing to change them, but I maintain that a base price of 1500 cents is a little much.

@Novacat
Copy link
Contributor

Novacat commented Nov 17, 2025

Edit: I have been informed that book values are already redefined in magiclysm, so my concern was unwarranted.

@RenechCDDA
Copy link
Member

I would argue that novels and other fiction books are pretty common and have limited use - If your only objection is the number itself, I would be willing to change them, but I maintain that a base price of 1500 cents is a little much.

The values you ar PRing are 50-100 cents, not 1500 cents.

@Inglonias
Copy link
Contributor Author

1500 cents is the current value

@RenechCDDA
Copy link
Member

Common items that are useful tend to be in the ~(250-2000) price range.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 17, 2025
@GuardianDll
Copy link
Member

we use this guide awfully rare, so i question how valid the approach described in it is, because, as it stands right now, the books totally match the guide, yet their price is deemed to be too high

@RenechCDDA
Copy link
Member

we use this guide awfully rare, so i question how valid the approach described in it is, because, as it stands right now, the books totally match the guide, yet their price is deemed to be too high

250(cents) would be in the price range.

And paying less attention to standards will not help. (Next week someone will come by and crank the prices right back up because [argument that it's too low].)

@GuardianDll
Copy link
Member

If it should be 250 cents, i tend to agree in this case

wonder if there is a chance we can CI it somehow and, most importantly, is it necessary

@Inglonias
Copy link
Contributor Author

I would be willing to raise the baseline price to 250 cents. It will have to be later though - I am currently away from my dev computer.

Hardcover books are now worth $3.50, and paperback are worth $2.50.
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 18, 2025
@Nebnis
Copy link
Contributor

Nebnis commented Nov 18, 2025

My argument that it should be high value is that entertainment is one of the 3 foundations of any society. It is security, food, and entertainment. If i were living in the Apocalypse, i would totally trade resources for movies or fiction books, not everything to do with survival has to do with staying alive, boredom is part of it too.

@Inglonias
Copy link
Contributor Author

Closing on the grounds that I don't wanna anymore. If someone else wants to do this, fine.

@Inglonias Inglonias closed this Nov 25, 2025
@GuardianDll
Copy link
Member

Looks good for me, if you don't mind, i would prefer to merge it as is

@GuardianDll GuardianDll reopened this Nov 25, 2025
@Inglonias
Copy link
Contributor Author

I do mind that you reopened the pull request after I closed it, but can't exactly stop you from merging it at this point.

@GuardianDll
Copy link
Member

Sorry, i saw it being unmerged only after you closed it
I didn't mean to be disrespectful, if that looked like i was

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 25, 2025
@GuardianDll GuardianDll merged commit fa14768 into CleverRaven:master Nov 25, 2025
56 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants