-
Notifications
You must be signed in to change notification settings - Fork 395
Feat/vue nodes try it now banner #6362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ac20b77
feat: first cut of vue nodes try it now banner
simula-r 4d4ae33
feat: first cut of vue nodes try it now banner
simula-r 812d64a
refactor: comments
simula-r 2f8b1af
fix: PR feedback
simula-r fd65e98
fix: litegraph test utils
simula-r afb7e2c
fix: global toast z-index
simula-r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| <template> | ||
| <div | ||
| v-if="showVueNodesBanner" | ||
| class="pointer-events-auto relative w-full h-10 bg-gradient-to-r from-blue-600 to-blue-700 flex items-center justify-center px-4" | ||
| > | ||
| <div class="flex items-center"> | ||
| <i class="icon-[lucide--sparkles]"></i> | ||
| <span class="pl-2">{{ $t('vueNodesBanner.message') }}</span> | ||
| <Button | ||
| class="cursor-pointer bg-transparent rounded h-7 px-3 border border-white text-white ml-4 text-xs" | ||
| @click="handleTryItOut" | ||
| > | ||
| {{ $t('vueNodesBanner.tryItOut') }} | ||
| </Button> | ||
| </div> | ||
| <Button | ||
| class="cursor-pointer bg-transparent border-0 outline-0 grid place-items-center absolute right-4" | ||
| unstyled | ||
| @click="handleDismiss" | ||
| > | ||
| <i class="w-5 h-5 icon-[lucide--x]"></i> | ||
| </Button> | ||
| </div> | ||
| </template> | ||
|
|
||
| <script setup lang="ts"> | ||
| import { useLocalStorage } from '@vueuse/core' | ||
| import Button from 'primevue/button' | ||
| import { computed } from 'vue' | ||
| import { useSettingStore } from '@/platform/settings/settingStore' | ||
| const STORAGE_KEY = 'vueNodesBannerDismissed' | ||
| const settingStore = useSettingStore() | ||
| const bannerDismissed = useLocalStorage(STORAGE_KEY, false) | ||
| const vueNodesEnabled = computed(() => { | ||
| try { | ||
| return settingStore.get('Comfy.VueNodes.Enabled') ?? false | ||
| } catch { | ||
| return false | ||
| } | ||
| }) | ||
| const showVueNodesBanner = computed(() => { | ||
| if (vueNodesEnabled.value) { | ||
| return false | ||
| } | ||
| if (bannerDismissed.value) { | ||
| return false | ||
| } | ||
| return true | ||
| }) | ||
| const handleDismiss = (): void => { | ||
| bannerDismissed.value = true | ||
| } | ||
| const handleTryItOut = async (): Promise<void> => { | ||
| try { | ||
| await settingStore.set('Comfy.VueNodes.Enabled', true) | ||
| } catch (error) { | ||
| console.error('Failed to enable Vue nodes:', error) | ||
| } finally { | ||
| handleDismiss() | ||
| } | ||
| } | ||
| </script> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.