Skip to content

Wrap Upward around RejectReason #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rbaconcordium merged 10 commits into from
Sep 5, 2025
Merged

Wrap Upward around RejectReason #497

rbaconcordium merged 10 commits into from
Sep 5, 2025

Conversation

@rbaconcordium
Copy link
Contributor

@rbaconcordium rbaconcordium commented Sep 4, 2025

Purpose

Introduce forward compatibility for RejectReason

Changes

Wrap Upward around RejectReason

Checklist

  • [ x ] My code follows the style of this project.
  • [ x ] The code compiles without warnings.
  • [ x ] I have performed a self-review of the changes.
  • [ x ] I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • [ x ] (If necessary) I have updated the CHANGELOG.

@rbaconcordium rbaconcordium force-pushed the forward-com/COR-1834-Reject-Reason branch 2 times, most recently from 639c447 to 7a298c1 Compare September 4, 2025 11:20
@rbaconcordium rbaconcordium force-pushed the forward-com/COR-1834-Reject-Reason branch from 7a298c1 to 0203bce Compare September 4, 2025 11:57
soerenbf
soerenbf approved these changes Sep 4, 2025
View reviewed changes
Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, mainly cosmetic/doc comments 😄

rbaconcordium and others added 8 commits September 4, 2025 13:43
@rbaconcordium @soerenbf
Update examples/nodejs/client/getBlockItemStatus.ts
6ce0679 
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
@rbaconcordium @soerenbf
Update examples/nodejs/plt/update-supply.ts
119cf44 
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
@rbaconcordium @soerenbf
Update examples/nodejs/plt/transfer.ts
8848c47 
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
@rbaconcordium @soerenbf
Update examples/nodejs/plt/modify-list.ts
c88c599 
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
@rbaconcordium @soerenbf
Update examples/nodejs/plt/pause.ts
f8f514a 
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
@rbaconcordium @soerenbf
Update packages/sdk/src/types/blockItemSummary.ts
181caaf 
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
@rbaconcordium @soerenbf
Update packages/sdk/src/types.ts
5e2e46f 
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
@soerenbf
fmt
87ac9c8
@rbaconcordium rbaconcordium merged commit 383ad91 into feature/forwards-compatibility Sep 5, 2025
11 checks passed
@rbaconcordium rbaconcordium deleted the forward-com/COR-1834-Reject-Reason branch September 5, 2025 08:38
@soerenbf soerenbf mentioned this pull request Sep 5, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soerenbf soerenbf soerenbf approved these changes

@DOBEN DOBEN Awaiting requested review from DOBEN

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rbaconcordium @soerenbf