-
Notifications
You must be signed in to change notification settings - Fork 18
Forward comp/creds #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Forward comp/creds #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in both read/write scenarios
2f5c5de to
3e19dbb
Compare
DOBEN
reviewed
Sep 9, 2025
DOBEN
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref COR-1718
Closes COR-1843, COR-1850
Purpose
Forwards compatibility for anything credential-related. This also introduces a type
Known<T>which unwrapsUpwardrecursively. Should be used with care though, as type information is lost when stripping, as it does not work with classes (which we use to strongly type our domain types).Changes
VerifyKeyreferences inUpwardChecklist
hard-to-understand areas.