Skip to content

making SelfDestroy virtual to fix #704 #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 3, 2025
Merged

making SelfDestroy virtual to fix #704 #705

merged 7 commits into from
Sep 3, 2025

Conversation

@hzqst
Copy link
Contributor

@hzqst hzqst commented Sep 3, 2025 •
edited
Loading

For #704

image

@hzqst hzqst mentioned this pull request Sep 3, 2025
Closed
@TheMostDiligent
Copy link
Contributor

TheMostDiligent commented Sep 3, 2025

I think that RefCountersAllocationImpl is not needed.
Just making SelfDestroy virtual should be enough.

@TheMostDiligent TheMostDiligent changed the base branch from master to development September 3, 2025 05:41
@hzqst hzqst changed the title Add RefCountersAllocationImpl for SelfDestroy making SelfDestroy virtual to fix #704 Sep 3, 2025
@TheMostDiligent TheMostDiligent merged commit 7f79a92 into DiligentGraphics:development Sep 3, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheMostDiligent TheMostDiligent Awaiting requested review from TheMostDiligent TheMostDiligent is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hzqst @TheMostDiligent