Skip to content

making SelfDestroy virtual to fix #704 #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 3, 2025
Merged

making SelfDestroy virtual to fix #704 #705

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b4f13b5
Add RefCountersAllocationImpl for SelfDestroy
hzqst Sep 3, 2025
ac79c85
fix formatting
hzqst Sep 3, 2025
d43146d
mark RefCountersAllocationImpl as final
hzqst Sep 3, 2025
8ef3e61
Making SelfDestroy virtual, remove final for RefCountersImpl.
hzqst Sep 3, 2025
d1810db
Add virtual dtor for IReferenceCounters
hzqst Sep 3, 2025
651da02
Add vdtor to RefCountersImpl, fix -Wdelete-non-abstract-non-virtual-d…
hzqst Sep 3, 2025
36326bc
fix dtor
hzqst Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Common/interface/RefCountedObjectImpl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ namespace Diligent
{

// This class controls the lifetime of a refcounted object
class RefCountersImpl final : public IReferenceCounters
class RefCountersImpl : public IReferenceCounters
{
public:
inline virtual ReferenceCounterValueType AddStrongRef() override final
Expand Down Expand Up @@ -448,12 +448,12 @@ class RefCountersImpl final : public IReferenceCounters
}
}

void SelfDestroy()
virtual void SelfDestroy()
{
delete this;
}

~RefCountersImpl()
virtual ~RefCountersImpl()
{
VERIFY(m_NumStrongReferences.load() == 0 && m_NumWeakReferences.load() == 0,
"There exist outstanding references to the object being destroyed");
Expand Down
Loading