Skip to content

Eliminate InitialState warning on d3d12 buffer creation #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Eliminate InitialState warning on d3d12 buffer creation #719

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8a86e2a
Fix https://github.com/DiligentGraphics/DiligentCore/issues/717
hzqst Oct 11, 2025
bcd8c43
Fix formatting
hzqst Oct 11, 2025
2231e07
Fix formatting.
hzqst Oct 11, 2025
bf0eb58
Rename GetUBName to GetUBOrSBName.
hzqst Oct 12, 2025
e9d3623
fix formatting.
hzqst Oct 12, 2025
f0e3f7c
Merge branch 'DiligentGraphics:master' into master
hzqst Oct 12, 2025
642f854
Merge branch 'DiligentGraphics:master' into master
hzqst Oct 18, 2025
60776b2
Fix DX WARNING: ID3D12Device::CreateCommittedResource: Ignoring Initi…
hzqst Oct 26, 2025
0b3f86b
We don't need StateMask anymore
hzqst Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions Graphics/GraphicsEngineD3D12/src/BufferD3D12Impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,12 +150,6 @@ BufferD3D12Impl::BufferD3D12Impl(IReferenceCounters* pRefCounters,
ClassPtrCast<DeviceContextD3D12Impl>(pBuffData->pContext)->GetCommandQueueId() :
SoftwareQueueIndex{PlatformMisc::GetLSB(m_Desc.ImmediateContextMask)};

const D3D12_RESOURCE_STATES StateMask = InitialDataSize > 0 ?
GetSupportedD3D12ResourceStatesForCommandList(pRenderDeviceD3D12->GetCommandQueueType(CmdQueueInd)) :
static_cast<D3D12_RESOURCE_STATES>(~0u);

const D3D12_RESOURCE_STATES d3d12State = ResourceStateFlagsToD3D12ResourceStates(GetState()) & StateMask;

// By default, committed resources and heaps are almost always zeroed upon creation.
// CREATE_NOT_ZEROED flag allows this to be elided in some scenarios to lower the overhead
// of creating the heap. No need to zero the resource if we initialize it.
Expand All @@ -164,7 +158,7 @@ BufferD3D12Impl::BufferD3D12Impl(IReferenceCounters* pRefCounters,
D3D12_HEAP_FLAG_NONE;

HRESULT hr = pd3d12Device->CreateCommittedResource(
&HeapProps, d3d12HeapFlags, &d3d12BuffDesc, d3d12State,
&HeapProps, d3d12HeapFlags, &d3d12BuffDesc, D3D12_RESOURCE_STATE_COMMON,
nullptr, // pOptimizedClearValue
__uuidof(m_pd3d12Resource),
reinterpret_cast<void**>(static_cast<ID3D12Resource**>(&m_pd3d12Resource)));
Expand Down
Loading